From patchwork Mon Jan 20 12:25:30 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikhil R X-Patchwork-Id: 105126 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A32093857C63 for ; Mon, 20 Jan 2025 12:26:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A32093857C63 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=TkWy0U5c X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by sourceware.org (Postfix) with ESMTPS id 13ABA3858289 for ; Mon, 20 Jan 2025 12:25:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13ABA3858289 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 13ABA3858289 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::329 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737375936; cv=none; b=BHq5P2NNW3MKYXHgjDdGcFw16u72/CVpiaaksTnHunPZr3qEhe4CXWnH3gNTpCZqCa0ojkCw6kkhryTV8ha8YaivKA2B4RrwQXu9e+YQK+2Jh2cd2qcDs/uf8e8PCtuqdY3mx0Oshv308pcF2ZhZNfxIZspPludGdesjvArOGT8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1737375936; c=relaxed/simple; bh=sAmJ5+L3KppVnR7D1KhiLRgpGN3KLZr47VIt452z5jM=; h=DKIM-Signature:From:To:Subject:Date:Message-Id; b=wSY8fuaoC3Jgmmix+4HXlduB5R1/Kg2Q/MUlOWtCKTh89TYcSojvd9wLTy3T0XQR2eWCPmawvbo55hvqMA9S0VI8yv4XeLBsUbEL+BuWa9iDbOTdvucb2UDrT5yuW2yujxnQOkqmJVTzRKVfmiIg9Xw9sReIt/hw9lhnUwck8RE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 13ABA3858289 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-43690d4605dso29719975e9.0 for ; Mon, 20 Jan 2025 04:25:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737375934; x=1737980734; darn=sourceware.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=luUteU+xFAGB6WEieucJXdxgBYu2xN+bmPMeHyt0t70=; b=TkWy0U5cOazsPWKA2RSZdshhn+ayOGQPOjHQsHo6r0rsbcRdiT4Zov9Ex86iEBGKRk SiyamLWQnZjXb5UrvDwrqdHoxKwcM24MKU+oTV2qwK7YxJhuQ61sRprcMPeKzQnE2N9B SC43n7bMjLCDRrWXfVyDw+VWBKpV4Hicy2GXqy/9rwBrlHwXGiWbXBFelOSABoVb+Y8X 4jTjVTlLmbzpPGl/ZkVONI0MU2dEFBbudsOroGNUOm6RwMrTXtObmyF0Kjt5dgLOIAqr ywQjgo/ZSS7pkfAELenAUidLt7XdM1Z9zy78aeT9NkxHNCF+rAiu7SeC1UzF2z9cIL5d CzWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737375934; x=1737980734; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=luUteU+xFAGB6WEieucJXdxgBYu2xN+bmPMeHyt0t70=; b=M24U0/if9juxYl7rpg0O/kMPx9QfZ3bmhsh2ngszI51lhXsvllS7IjdGERnwDerMxp L5oYkVNSPX008D+sHEA441a5pBmcOkNjc7QqCFr9p5wxZuR6VQHu7m9XyhuZ2kQYVDoj 1GMHG+D2iccmenGe7WFuk4wNhDKR/WF8OdoT2jcbbCnu+2+/l/X5fR9O2xIdDBPmHRmY Ul6O8VpaQ8DJZxnZNb5uKn4KzSdsFuf/sm+Lawmc6PALWbElxleVHPB7ns5DERxi6T5F Zxu2zbRmBtgc+GX8cSzgJJoDfkumpXRtBzh5Q5dOQKOmOPOHdXt4eCdNunsK0TJLX9gV tGfg== X-Gm-Message-State: AOJu0YzJWbBfStCh7/o40XbIyLAzjypYNEDjmEvWnzbpbm1T1igeEneL VvjEGojuEhvnghM/ikjeuVxX97pOoQKegMzIcwHXPOQ7ui/IwlXgaqZEX8QPtw== X-Gm-Gg: ASbGncscC2V3Q1FpcZovxC0WsJlXkZ5IPuhj+YPjRAiBtq7eNN7/FuML2giXZ0scEw6 f2GEyodZabLNZT0aRs/oSAfbcWIKzRRmY1q78Fkokm1Hewm7xJen2vNVbliF4LThRc9Tnl8fnBv fp0hX8pcAy4KHTj1Tn0/BB2TQLUl/hb+yK0OolM6X23HdU2dNq2tluiWtTf1JcH9HpQwe5tTJJC uuldr3FtqF+dn8pnVcDh9VcZBKGMtTfu1iSVSOXrI8/FcGbnuTxyxRKtfHnmNdmLm3GhqSlXWqp ZqPO1Kz/ZEY= X-Google-Smtp-Source: AGHT+IHNpxywNCIHChw0qZzrp2tY25SnDfvj1YkrImHZqSjfhLpqGtlkls0GOULocJVqyYEjenkpTQ== X-Received: by 2002:a05:600c:3b02:b0:434:a7f1:6545 with SMTP id 5b1f17b1804b1-43891441f27mr110350295e9.27.1737375933709; Mon, 20 Jan 2025 04:25:33 -0800 (PST) Received: from GIW-21.bmw-carit.intra ([212.118.206.70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-438a1ec39a3sm86856115e9.16.2025.01.20.04.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 04:25:33 -0800 (PST) From: Nikhil R To: libc-alpha@sourceware.org Cc: Nikhil R Subject: [PATCH] canonicalize: Fix uninitialized 'dest' in realpath_stk for glibc 2.35 [BZ #32577] Date: Mon, 20 Jan 2025 13:25:30 +0100 Message-Id: <20250120122530.40339-1-nikhilar2410@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Fixes a GCC warning when compiling with the '-Os' optimization flag: | canonicalize.c: In function 'realpath_stk': | canonicalize.c:424:50: error: 'dest' may be used uninitialized in this function [-Werror=maybe-uninitialized] | 424 | return scratch_buffer_dupfree (rname_buf, dest - rname); Issue specific to glibc 2.35. Signed-off-by: Nikhil R --- stdlib/canonicalize.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stdlib/canonicalize.c b/stdlib/canonicalize.c index 6caed9e70e..061d3b3062 100644 --- a/stdlib/canonicalize.c +++ b/stdlib/canonicalize.c @@ -198,7 +198,7 @@ static char * realpath_stk (const char *name, char *resolved, struct scratch_buffer *rname_buf) { - char *dest; + char *dest = NULL; char const *start; char const *end; int num_links = 0;