can't find file to patch at input line 189 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -------------------------- |From patchwork Fri Oct 29 15:27:29 2021 |Content-Type: text/plain; charset="utf-8" |MIME-Version: 1.0 |Content-Transfer-Encoding: 8bit |X-Patchwork-Submitter: Alejandro Colomar |X-Patchwork-Id: 46791 |Return-Path: |X-Original-To: patchwork@sourceware.org |Delivered-To: patchwork@sourceware.org |Received: from server2.sourceware.org (localhost [IPv6:::1]) | by sourceware.org (Postfix) with ESMTP id 167053857802 | for ; Fri, 29 Oct 2021 15:29:41 +0000 (GMT) |DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 167053857802 |DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; | s=default; t=1635521381; | bh=KhbqOXnoHXwyC+f7gmkg5ckm2abm1xltijn+kiK9wfs=; | h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: | List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: | From; | b=vsuE+EBVxKIuFY/PXfntRtVWxcfF3Ar4XDVFp4yrJzsFRyP3yvllqILZexuaNOhdt | BNu1RK/hab5GEOPufQsX/FulUqIFGuuY6XWkEny4VfX5wG2E+KUhASQeewnK6L89rQ | v/7FLJ2cx5ldNEwu/xj0/FUS+Jemee1YQiOzCu0s= |X-Original-To: libc-alpha@sourceware.org |Delivered-To: libc-alpha@sourceware.org |Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com | [IPv6:2a00:1450:4864:20::42f]) | by sourceware.org (Postfix) with ESMTPS id 83B7D3858410 | for ; Fri, 29 Oct 2021 15:29:19 +0000 (GMT) |DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 83B7D3858410 |Received: by mail-wr1-x42f.google.com with SMTP id d13so16669610wrf.11 | for ; Fri, 29 Oct 2021 08:29:19 -0700 (PDT) |X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; | d=1e100.net; s=20210112; | h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to | :references:mime-version:content-transfer-encoding; | bh=KhbqOXnoHXwyC+f7gmkg5ckm2abm1xltijn+kiK9wfs=; | b=bkG/GyL7808AJvBczyaTy4U3ZQQXsCn8ECWT2B9QVE21ap3tbZR+mxiDQeUThEb48b | fFNAOLtS2JcaXW6lnMVrbdsf0bV1WRtdq2uV1wTPags6ybZyvMuWOcsFhMkG60V66jT7 | BPiuEnHBBOfwIX3xOpBZAXDmKheAaCzFby1bmkpr67xYpG8/2xNMeer20npZRuAgP/e2 | NTrFxVh23oZ3nEPXsBcUJzzP8IbypSpR0ts4vFEr7Zvbl+zPKRP1u7pZD/loQrdzykQy | 5lNWPx/2ev7bEcuCeSIJ7GrhJNJgXrnzqqukS6+nrDNca2egnOHJbhfCt8+MFQ+Bffq7 | ZQHg== |X-Gm-Message-State: AOAM530H3A36ply1elFev8xsbscHXUaOqCerV1CVFOtnkmU06kPSytjT | PHelvZtR5udWNNvGRJzEkb4= |X-Google-Smtp-Source: | ABdhPJxwB+0uH4h5PTmB8QYQVrp6xpguAo2+sVaW1C/1PNXpdJtXo4lWSZv1cRc9i9t+wCgZlvhvjA== |X-Received: by 2002:a5d:5244:: with SMTP id k4mr3880987wrc.77.1635521358292; | Fri, 29 Oct 2021 08:29:18 -0700 (PDT) |Received: from sqli.sqli.com ([195.53.121.100]) | by smtp.googlemail.com with ESMTPSA id p12sm6598235wrr.67.2021.10.29.08.29.16 | (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); | Fri, 29 Oct 2021 08:29:17 -0700 (PDT) |To: mtk.manpages@gmail.com, | linux-man@vger.kernel.org |Subject: [PATCH] getpass.3: SYNOPSIS: Mark getpass() as [[deprecated]] |Date: Fri, 29 Oct 2021 17:27:29 +0200 |Message-Id: <20211029152728.42938-1-alx.manpages@gmail.com> |X-Mailer: git-send-email 2.33.1 |In-Reply-To: <73ac38a2-c287-4cc1-4e9c-0f9766ac4c0c@gmail.com> |References: <73ac38a2-c287-4cc1-4e9c-0f9766ac4c0c@gmail.com> |MIME-Version: 1.0 |X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, | DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, | RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, | TXREP autolearn=ham autolearn_force=no version=3.4.4 |X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on | server2.sourceware.org |X-BeenThere: libc-alpha@sourceware.org |X-Mailman-Version: 2.1.29 |Precedence: list |List-Id: Libc-alpha mailing list |List-Unsubscribe: , | |List-Archive: |List-Post: |List-Help: |List-Subscribe: , | |X-Patchwork-Original-From: Alejandro Colomar via Libc-alpha | |From: Alejandro Colomar |Reply-To: Alejandro Colomar |Cc: Alejandro Colomar , | Randall , Glibc , | Theo de Raadt , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFy?= | =?utf-8?b?bWFzb24=?= , OpenBSD , | Klemens Nanni , Zack Weinberg , | Benoit Lecocq , Eugene Syromyatnikov , | Git |Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org |Sender: "Libc-alpha" | | |Suggest readpassphrase(3bsd) as an alternative. | |See the long discussion in the mailing list for more details (link |at the bottom of this commit message). I'll quote some relevant |parts here: | |Eugene Syromyatnikov : |{ | And the only mention of getpass() in POSIX (at least, | since the 2001's edition) indeed seems to be [1], in the | list of functions that have not been carried forward from | XSH5, the 1997 revision of “System Interfaces and Headers” | (that is, SUSv2)[2], where it is inherited from SUSv1[4] | from XPG[5] and, as Alejandro already mentioned, marked as | obsolete, per XPG3 to XPG4 migration guide[6]; the | previous, 1988, version of POSIX[3] does not mention | getpass() at all. | | [1] https://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap01.html | [2] https://pubs.opengroup.org/onlinepubs/7908799/xsh/getpass.html | [3] https://mirror.math.princeton.edu/pub/oldlinux/download/c953.pdf | [4] https://pubs.opengroup.org/onlinepubs/9695969499/toc.pdf | [5] https://bitsavers.computerhistory.org/pdf/xOpen/X_Open_Portability_Guide_1985/xpg_2_xopen_system_v_specification_2.pdf | [6] http://archive.opengroup.org/publications/archive/CDROM/g501.pdf |} | |Theo de Raadt : |{ | The community finally had the balls to get rid of gets(3). | | getpass(3) shares the same flaw, that the buffer size | isn't passed. This has been an issue in the past, and | incorrectly led to readpassphrase(3). | | readpassphrase(3) has a few too many features/extensions | for my taste, but at least it is harder to abuse. |} | |Alejandro Colomar : |{ | I found readpassphrase(3) in FreeBSD and OpenBSD. It is | also present in libbsd(7), which is available in most | Linux distributions. I also found it on a Mac that I have | access. | | NetBSD has getpass_r(3) instead. It is not in any other | system I have access. |} | |Zack Weinberg : |{ | I was about to post exactly the same thing. getpass(3) | is not deprecated because there's a better replacement, | it's deprecated because it's _unsafe_. The glibc | implementation wraps getline(3) and therefore doesn't | truncate the passphrase or overflow a fixed-size buffer, | no matter how long the input is, but portable code cannot | rely on that. And come to think of it, using getline(3) | means that prefixes of the passphrase may be left lying | around in malloc's free lists. | | (getpass also cannot be made thread safe, due to recycling | of a static buffer, but a program in which multiple | threads are racing to prompt the user for passwords would | be a UX disaster anyway, so I don't think that's a | critical flaw the way it is for e.g. strtok(3).) | | The Linux manpage project's documentation is, as I | understand it, for Linux with glibc _first_, but not | _only_; it should not describe this function as | not-deprecated just because glibc has patched its worst | problems and doesn't offer any better API. |} | |List: linux-man |Signed-off-by: Alejandro Colomar |Cc: Git |Cc: Glibc |Cc: OpenBSD |Cc: Ævar Arnfjörð Bjarmason |Cc: Benoit Lecocq |Cc: Klemens Nanni |Cc: Randall |Cc: Eugene Syromyatnikov |Cc: Theo de Raadt |Cc: Zack Weinberg |Cc: Florian Weimer |--- | man3/getpass.3 | 9 +++++++-- | 1 file changed, 7 insertions(+), 2 deletions(-) | |diff --git a/man3/getpass.3 b/man3/getpass.3 |index fa2031544..7d6da07fa 100644 |--- a/man3/getpass.3 |+++ b/man3/getpass.3 -------------------------- File to patch: Skip this patch? [y] Skipping patch. 3 out of 3 hunks ignored