From patchwork Tue Jan 7 00:37:33 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Thibault X-Patchwork-Id: 104202 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 30C7B3858D29 for ; Tue, 7 Jan 2025 00:38:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 30C7B3858D29 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from sonata.ens-lyon.org (domu-toccata.ens-lyon.fr [140.77.166.138]) by sourceware.org (Postfix) with ESMTPS id 284FF3858C98 for ; Tue, 7 Jan 2025 00:37:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 284FF3858C98 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=ens-lyon.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bounce.ens-lyon.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 284FF3858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.77.166.138 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736210255; cv=none; b=SpwiuoCkGFvavrZY0rpns/lgfDKFM/ixJ/Ti2hjZi9LT7BAN+VAZLvCnDXlBP661C8zj3ZRLAbBlrWv+iXS0jevxLNeRf4vzi/emmyBGbyteV7B3hupxPk7qA/V8l2SL98qzg31ne3TPr8MjCxlO/DZuyXaMdZcpdWw1WJnXR60= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736210255; c=relaxed/simple; bh=DwN1JrMeUI/HI4Egkkh7Rixp4ow8rP7sbO393/pFIyU=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=fqVKDsB+0t3iIv2OA1mWsyKREQgfq7BzVjYpm5tFddNFr37G0PjL49EUXARfClDJfjoQEE9c320Pa3pirIsShiZRpEBKUA+pswEjpawkkJHxb4e8hT4NJkMP4l8vN3xw3mkNQHFcHn3JAtlrlRG1BrtJNBkS+wIHu5A9r779kLw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 284FF3858C98 Received: from localhost (localhost [127.0.0.1]) by sonata.ens-lyon.org (Postfix) with ESMTP id 3F0DFA047A; Tue, 7 Jan 2025 01:37:34 +0100 (CET) Received: from sonata.ens-lyon.org ([127.0.0.1]) by localhost (sonata.ens-lyon.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qMBFj-3DRfbx; Tue, 7 Jan 2025 01:37:34 +0100 (CET) Received: from begin.home (aamiens-653-1-40-48.w83-192.abo.wanadoo.fr [83.192.199.48]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by sonata.ens-lyon.org (Postfix) with ESMTPSA id 1833EA0408; Tue, 7 Jan 2025 01:37:34 +0100 (CET) Received: from samy by begin.home with local (Exim 4.98) (envelope-from ) id 1tUxbB-0000000HQQF-0m5Y; Tue, 07 Jan 2025 01:37:33 +0100 From: Samuel Thibault To: libc-alpha@sourceware.org Cc: Samuel Thibault , commit-hurd@gnu.org Subject: [hurd,commited] hurd: Accept null arguments for utimensat pathname Date: Tue, 7 Jan 2025 01:37:33 +0100 Message-ID: <20250107003733.4153136-1-samuel.thibault@ens-lyon.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org This follows Linux' behavior, making it a replacement for the futimens interface. --- sysdeps/mach/hurd/utimensat.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/sysdeps/mach/hurd/utimensat.c b/sysdeps/mach/hurd/utimensat.c index 97968690e9..4d0edc0962 100644 --- a/sysdeps/mach/hurd/utimensat.c +++ b/sysdeps/mach/hurd/utimensat.c @@ -33,13 +33,19 @@ utimensat (int fd, const char *file, const struct timespec tsp[2], error_t err; file_t port; - port = __file_name_lookup_at (fd, flags, file, 0, 0); - if (port == MACH_PORT_NULL) - return -1; + if (file) + { + port = __file_name_lookup_at (fd, flags, file, 0, 0); + if (port == MACH_PORT_NULL) + return -1; - err = hurd_futimens (port, tsp); + err = hurd_futimens (port, tsp); + + __mach_port_deallocate (__mach_task_self (), port); + } + else + err = HURD_DPORT_USE (fd, hurd_futimens (port, tsp)); - __mach_port_deallocate (__mach_task_self (), port); if (err) return __hurd_fail (err); return 0;