From patchwork Sun Dec 22 04:12:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: DJ Delorie X-Patchwork-Id: 103609 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BC931385840D for ; Sun, 22 Dec 2024 04:13:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC931385840D Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EythQLRf X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 073273858D3C for ; Sun, 22 Dec 2024 04:12:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 073273858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 073273858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734840769; cv=none; b=ezH71zMm3lpHUXsQClLqHACzMNA0ATyvo7MIKgKMT8iRiNkHVM5EpbIF1zwahYuV6++02qrDdRgj9KDvBzau0m+okcrQDIpOSr9UOSNQRwwwO9V5HYEfZd6gOHuz5CvyrV+RSPAnlkRqm+5YpGSq0eWAjTqAcOTybi5J6dxKWBU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734840769; c=relaxed/simple; bh=Ece9c4x5jdSmKQi4LL9aAzeHYQ7V5Xa1GhNgXPVk72I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JsD1disyUgygxnJPIlDAt4vgIb9TWbPxLZQUz4qVA4JtOMqqwuV8jMzNcqEke5vJbvjDojT6HyFmwrXsHyTUD2g+BbyS6TYcfU3u+5Gx/7zeJeQd14dYIhjwdwn0KXWJJ8lszZ2gGfOVi9tMkuDxCoLcAYEkx3/Fr80FjNtLaLU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 073273858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734840768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to; bh=TDbdfwg6vgjHu7iN4CHa9u5LYV6hPYTN0IpvEp2TH5A=; b=EythQLRfYUvFi6dIU2KLvyvf1lg0Y5t+JASwNDjRC5hRqEBJGYaYsp8GtMgMPCrFTk8dvP glRa9ufvM6aN+5UKNr04yjeb8YHjPEidJJ8H5IwW+vlDpQFmMsux72ur8qzjygF8X9WyPt drMx3ReoSegN0A+BwYUEbVUM6/agFwM= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-407-54QHOexoOZ-qtGB1JDgHFw-1; Sat, 21 Dec 2024 23:12:45 -0500 X-MC-Unique: 54QHOexoOZ-qtGB1JDgHFw-1 X-Mimecast-MFC-AGG-ID: 54QHOexoOZ-qtGB1JDgHFw Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6FDBB19560B1; Sun, 22 Dec 2024 04:12:44 +0000 (UTC) Received: from greed.delorie.com (unknown [10.22.89.82]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 08BE419560AA; Sun, 22 Dec 2024 04:12:43 +0000 (UTC) Received: from greed.delorie.com.redhat.com (localhost [127.0.0.1]) by greed.delorie.com (8.16.1/8.16.1) with ESMTP id 4BM4CfbH3554136; Sat, 21 Dec 2024 23:12:41 -0500 From: DJ Delorie To: "H.J. Lu" Cc: eggert@cs.ucla.edu, libc-alpha@sourceware.org, fweimer@redhat.com Subject: [patch v1 1/1] assert: use internal symbols [BZ #32492] such In-Reply-To: (hjl.tools@gmail.com) Date: Sat, 21 Dec 2024 23:12:41 -0500 Message-ID: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: luX0vgVrt-O-d9A7Yqh5xMdKzaVGaNYIMjfHP4GOPrE_1734840764 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org "H.J. Lu" writes: > It also caused: > > https://sourceware.org/bugzilla/show_bug.cgi?id=32492 How about this? Reviewed-by: H.J. Lu --- Use __writev instead of writev to avoid polluting the external namespace. Resolves: #32492 diff --git a/assert/assert.c b/assert/assert.c index a271125f08..3a16f85394 100644 --- a/assert/assert.c +++ b/assert/assert.c @@ -117,7 +117,7 @@ __assert_fail_base (const char *fmt, const char *assertion, const char *file, this code path is taken. */ WS ("' failed\n"); - (void) writev (STDERR_FILENO, v, i); + (void) __writev (STDERR_FILENO, v, i); } abort ();