From patchwork Sat Dec 21 22:31:51 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 103561 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B709F3858C54 for ; Sat, 21 Dec 2024 22:32:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B709F3858C54 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=K1cXUSvp X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 659093858D3C for ; Sat, 21 Dec 2024 22:32:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 659093858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 659093858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734820320; cv=none; b=jc5q/d9CPUSGMSYTa/qBsV7Aooom+GXkh9ugbHJCcZRruJ6rhc05LB923FBJ5htFXQVMG35MtxDzrRm/H1YZa+2o16iHkjtf8Uyi4ez4j1WLmc4ZMU4wL7xTxKN0RlllPLrb2833IpxsA0zACwQbJS06MzqdWpgcIraobbOxF1w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734820320; c=relaxed/simple; bh=60aO+vqvszoqyZ99DK0Lwu7IyjMW1DU970S/HNr/dJ4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hjXCHM1R6NxVe4oIUBWZI3d6zuwOappEb+SMMYvgrtzz6xUnzQLSR35sFnrJRJoK38gcBGAGKdf+zlZx42/s3VJ72+Hrt2NBIKvwbDm1cibz4nIcFzNmvU43r0WqQi4SD67jYxf6H9sm4Xb4JsMIzCIjRCXuvGsVSPAhW7HKLEU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 659093858D3C Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-2156e078563so27555395ad.2 for ; Sat, 21 Dec 2024 14:32:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734820319; x=1735425119; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XaCvP1i0ZSmigFbGBuLfiEuC4tsM2SQJq90Jr1Z8Ydc=; b=K1cXUSvpA0TjtTtVaRbDbaBpKby6zA+8vzQ4ceGx946xVBP7rkpnAEudMSbEWSS7sV Qgfp4wKSP09PSuFat0EFG8idYtwps/Cf2sSzwzPu7aiTLtre/4b1jrIi4mwVwuOrkK7g PWpswi2g0QBp1KSw129Ol7tHyk2gwWa7VVexFhwlYomLeDNaILfdvz/NJcvyUghiVzhR 39jZemdjsRtrtZ1yOkQnmgIt+cwsWXfwvHrRMKOnYglRwAdpcAbYhRQ00ZiljIAKn1nt c0Wfd4QadLc3zd/qiSTzH8KrTy6yMubC5j1r/fCmboOYuVFfWPgfLfKTpEh3oIpGOCUS Ungg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734820319; x=1735425119; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XaCvP1i0ZSmigFbGBuLfiEuC4tsM2SQJq90Jr1Z8Ydc=; b=Fwjto+Y4JkS/3bbxFAVjNFvwcjDaWFomm0PIrqDfZBRQwog5A09v9X/MMI5MLw051u ug8uns0Uq5QpmDD70mramkdGC5siGyJSza3+3MT/gORf2t2BhI/m9ru7jhHYyGLeQPum 0AFCoehAAWqV1iZ3nLhJ7jTo11dmjFFKlcaLK4/gtqWRadlSm7Jxch9G9mWRNj7M824p g0DsSeK0z9zG7yD7m7CFl4kuyT2gkn53z4z9JEXAf2lKkT6MXSf3ZZkIW5fDMH50e+JB NXwiKJT0S559AakQ5t+WiFHHG0kAk0F9zcTHGsk8JLlpMT0BxSg3mbblUNuzTlT7l9Kx yZ1Q== X-Gm-Message-State: AOJu0YwWoLH4eeFLpOJjG+fT8Aq4OzW+1V6nXAnM4uKJmI5xJc75kqYO UFlb+HmlhlUwIWEn0NK7u2UKrm1nP/Es/ejhWxg9yVrHASbYUkvdtWnTCljCvGPGIA== X-Gm-Gg: ASbGncuzDqy7IWKKcoOfc3h0qGO7M7tKVRMXG8UMsFTzjLCYM+Kiwv2O70ukc0XavVA RXlT7QFeHlOcN8iJ7h263XDCKv6RAvikRuaU9NX8l1GNE8o8TgsrdUEK0vUs9BCvVnH/rqfhD9b YdEB9cdDPORdcmSqa+xIu3vDWv2Sz9PkWtaobuXnb1w7vkI+C8aBMLqwNy7dSnNWEmjwx7hzGQm jdClRMh58MGEmbhwIRp9Rt3AnIgHdJ6nm3FIYeJQ0pT7/DGqNPYcxNmFZugyPHIxgGvAZ4= X-Google-Smtp-Source: AGHT+IHr1CKHaRt3Nle4+md3TjTaR174m8pndq1d5p3THaHkPVTzah5ESSxzD2FA686SUx8ATHGpJQ== X-Received: by 2002:a17:903:2282:b0:216:59ed:1ab0 with SMTP id d9443c01a7336-219e6eb3b88mr90390405ad.27.1734820319391; Sat, 21 Dec 2024 14:31:59 -0800 (PST) Received: from gnu-tgl-3.localdomain ([120.204.185.181]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-219dc972b29sm48525205ad.111.2024.12.21.14.31.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Dec 2024 14:31:59 -0800 (PST) Received: from gnu-tgl-3.lan (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id 8486FC028A; Sun, 22 Dec 2024 06:31:55 +0800 (CST) From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: Adhemerval Zanella Subject: [PATCH] dirent: Remove variable lenght array structure for tst-getdents64.c Date: Sun, 22 Dec 2024 06:31:51 +0800 Message-ID: <20241221223151.753925-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3019.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org From: Adhemerval Zanella Clang emits the following warnings: ../sysdeps/unix/sysv/linux/tst-getdents64.c:111:18: error: fields must have a constant size: 'variable length array in structure' extension will never be supported char buffer[buffer_size]; ^ Co-Authored-By: H.J. Lu --- sysdeps/unix/sysv/linux/tst-getdents64.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/sysdeps/unix/sysv/linux/tst-getdents64.c b/sysdeps/unix/sysv/linux/tst-getdents64.c index ba66d49a2e..feba24d7b4 100644 --- a/sysdeps/unix/sysv/linux/tst-getdents64.c +++ b/sysdeps/unix/sysv/linux/tst-getdents64.c @@ -103,6 +103,8 @@ do_test_by_size (size_t buffer_size) int fd = xopen (".", O_RDONLY | O_DIRECTORY, 0); TEST_VERIFY (fd >= 0); + char *data = xposix_memalign (_Alignof (struct dirent64), buffer_size); + /* Perform two passes, with a rewind operating between passes. */ for (int pass = 0; pass < 2; ++pass) { @@ -111,23 +113,15 @@ do_test_by_size (size_t buffer_size) while (true) { - /* Simple way to make sure that the memcpy below does not read - non-existing data. */ - struct - { - char buffer[buffer_size]; - struct dirent64 pad; - } data; - - ssize_t ret = getdents64 (fd, &data.buffer, sizeof (data.buffer)); + ssize_t ret = getdents64 (fd, data, buffer_size); if (ret < 0) FAIL_EXIT1 ("getdents64: %m"); if (ret == 0) break; ++read_count; - char *current = data.buffer; - char *end = data.buffer + ret; + char *current = data; + char *end = data + ret; while (current != end) { struct dirent64 entry; @@ -170,6 +164,8 @@ do_test_by_size (size_t buffer_size) rewinddir (reference); } + free (data); + xclose (fd); closedir (reference); }