From patchwork Wed Dec 18 19:00:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 103374 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F20EA3858C51 for ; Wed, 18 Dec 2024 19:01:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F20EA3858C51 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=AqcK7wZ6 X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 4B3BF3858D20 for ; Wed, 18 Dec 2024 19:00:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4B3BF3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4B3BF3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734548449; cv=none; b=DO0LyMC+bzfWHoJMRLS7p+s6t6V2bek8yUErVq8yhPsDz1a3U9e2WUzIQssNo7pg2O9XIbJUZXuX93S7UJez4w4tV+0O4wBT8NmWbtWZjq5nQazgJKwROtlffbeTbD8EADhnE4waVKQL1O0SUijWxdnAxNaJEOnOBuYm9jtSekQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734548449; c=relaxed/simple; bh=+w+EWIIH2jWkgpK3qOfHDEHKlL5OTJIcH3M5BJeWZI8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kwmh6z5C8OJepd4uHAawwRRuDzLdbiOpl5+bQYYZONJEJloEt6EY//gyKxAr/GmfrdDJkypwN2zaX7PU8jqoiVM0/0Bu8WWqPJrV7bzC2W7ZXn97YQOU9ioMCk6Qht5HhZZHVTDz8I7Y2ZJ9EUheKWWs4/B5m2JSztGMdi7mzfc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B3BF3858D20 Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-3ab2f414695so22334975ab.0 for ; Wed, 18 Dec 2024 11:00:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734548448; x=1735153248; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+j+0yQa0wzSq0jLIkOy+KPcxAkuUDsPYVOi7pmDuCOY=; b=AqcK7wZ6UP/8qyYtFbAGHuHPWDYvMLELK2TfgwQ47Z1wEBjfa+O8rf6vVqovSfvsu1 xV9yIUjCmYsqhqx3S59yJyxnruT2mXIY5o3MAU72oh7tyPmRK0AJf6FvoCVvYPEv9exq vHssIMaYGFYBVB8YeHbWNYH0mZSvPWpJpm1amqSuoul3nEYsDcvHh3CQv1jussCHLbUB 0kJT9g8DIFJFUqFnFo8x3372uiBXTt3CvgyE9nBvWbrt562MOR/ef29z7uDw/e9YsAeU qtSb2W8vUsye1u7QsZ3Fvqh8Tc43q7JInBLG3+u/RsEkwIBHO5NnfWxMUyhD1YRPxb/R D9Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734548448; x=1735153248; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+j+0yQa0wzSq0jLIkOy+KPcxAkuUDsPYVOi7pmDuCOY=; b=Vie9g2LswFxRchvTZB7LCCxjhDEgDcxJIJyJJLf7y87Ef90CBkJ2U+/oa1u1GB+8/w yiIIFWKJbXTwq3Hg08uXIP9WkvveEMzYN6m/g3b4SueynpsWOi6hmYGf0p/E2RfwItpk YiYrC9WIrkvQbhSlK5RxAP9RIROZkt/+XkTQVKjJUHXoIfIfgqhQQI5bbLYICWUGQOBm T9+ja8htL9jil/Cth9aNFNHv43en1CzSD7xdZR7r4U2CNMp5D2yliRUfpyqKXY3pfDtk tsvf0pLpEBSA0diiy3hPd4bQWjzRqFWLh/Zfoi4qxnUToxumGHxC1/8Za0XZTIVVpZwV FosQ== X-Gm-Message-State: AOJu0Yyw93rcG+j2uq5tPnjTBtl6qFthG/Hlu7Vk6jJ4BTlX3aA0YFc+ ppnLCHQo4xldASl4uOpoxQDjIGQwXe4mKuREhFQ/1HmpRpzwpLxwUbEzHuyLjHEGnLo8rAw= X-Gm-Gg: ASbGnctb1PVNUkvGpMg8GzBUd0NNJZbu3uoEXlAfoz/fA2UzFFwgexethmyqFurRJj2 tHYwA+lyzt6Ezuai2Ja9iswDkeLVLEZV29Cwb47XwGsTtmFQ9Kw6z7D0UVyBQpyMFx6QKisnkES +Mwl3VZtY3POrAiqwO8ZruxqaJ79XgyKi77q0wq183z1POCQzjzCT4RFMnsB/PYxV4NnL2ojmje Bs+VX4VEBpzLUJ3U50PLe5RCLMfgzMCtB0EXAEbSzWQ8l3q5IzgQZcjAQ/kDynvzXML4AF4lawT hjk7QFVAfWBIck635j+nsoTAX46o+06hAYNd4LURaMun X-Google-Smtp-Source: AGHT+IEyD4Ns7MOAeWDqkhzo3e/GKy9kMgcypITwi7pKB9b2q8Le24/6/xJjGk3K64kl0gS2a1zqCQ== X-Received: by 2002:a05:6e02:3497:b0:3a7:e86a:e812 with SMTP id e9e14a558f8ab-3c0145b1451mr6043425ab.17.1734548448326; Wed, 18 Dec 2024 11:00:48 -0800 (PST) Received: from gnu-tgl-3.localdomain ([172.58.139.71]) by smtp.gmail.com with ESMTPSA id e9e14a558f8ab-3b248dac8ebsm28804285ab.46.2024.12.18.11.00.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 11:00:47 -0800 (PST) Received: from gnu-tgl-3.. (localhost [IPv6:::1]) by gnu-tgl-3.localdomain (Postfix) with ESMTP id 6F461C0231; Thu, 19 Dec 2024 03:00:43 +0800 (CST) From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: Fangrui Song , Fangrui Song Subject: [PATCH v2] x86: Define __HAVE_FLOAT128 for Clang and use __builtin_*f128 code path Date: Thu, 19 Dec 2024 03:00:41 +0800 Message-ID: <20241218190041.2464446-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.47.1 MIME-Version: 1.0 X-Spam-Status: No, score=-3017.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org From: Fangrui Song Clang supports __builtin_fabsf128 (despite not supporting _Float128) but it does not support __builtin_fabsq. Fallback to back to `typedef __float128 _Float128;` it clang is used. Authored-by: Fangrui Song --- sysdeps/x86/bits/floatn.h | 21 ++++++++++++++------- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/sysdeps/x86/bits/floatn.h b/sysdeps/x86/bits/floatn.h index e661abaea4..8849b811bc 100644 --- a/sysdeps/x86/bits/floatn.h +++ b/sysdeps/x86/bits/floatn.h @@ -28,7 +28,8 @@ support, for x86_64 and x86. */ #if (defined __x86_64__ \ ? __GNUC_PREREQ (4, 3) \ - : (defined __GNU__ ? __GNUC_PREREQ (4, 5) : __GNUC_PREREQ (4, 4))) + : (defined __GNU__ ? __GNUC_PREREQ (4, 5) : __GNUC_PREREQ (4, 4))) \ + || defined __clang__ # define __HAVE_FLOAT128 1 #else # define __HAVE_FLOAT128 0 @@ -58,7 +59,9 @@ /* Defined to concatenate the literal suffix to be used with _Float128 types, if __HAVE_FLOAT128 is 1. */ # if __HAVE_FLOAT128 -# if !__GNUC_PREREQ (7, 0) || (defined __cplusplus && !__GNUC_PREREQ (13, 0)) +# if !__GNUC_PREREQ (7, 0) \ + || (defined __cplusplus && !__GNUC_PREREQ (13, 0)) \ + || defined __clang__ /* The literal suffix f128 exists only since GCC 7.0. */ # define __f128(x) x##q # else @@ -68,7 +71,9 @@ /* Defined to a complex binary128 type if __HAVE_FLOAT128 is 1. */ # if __HAVE_FLOAT128 -# if !__GNUC_PREREQ (7, 0) || (defined __cplusplus && !__GNUC_PREREQ (13, 0)) +# if !__GNUC_PREREQ (7, 0) \ + || (defined __cplusplus && !__GNUC_PREREQ (13, 0)) \ + || defined __clang__ /* Add a typedef for older GCC compilers which don't natively support _Complex _Float128. */ typedef _Complex float __cfloat128 __attribute__ ((__mode__ (__TC__))); @@ -82,12 +87,14 @@ typedef _Complex float __cfloat128 __attribute__ ((__mode__ (__TC__))); # if __HAVE_FLOAT128 /* The type _Float128 exists only since GCC 7.0. */ -# if !__GNUC_PREREQ (7, 0) || (defined __cplusplus && !__GNUC_PREREQ (13, 0)) +# if !__GNUC_PREREQ (7, 0) \ + || (defined __cplusplus && !__GNUC_PREREQ (13, 0)) \ + || defined __clang__ typedef __float128 _Float128; # endif /* __builtin_huge_valf128 doesn't exist before GCC 7.0. */ -# if !__GNUC_PREREQ (7, 0) +# if !__GNUC_PREREQ (7, 0) && !defined __clang__ # define __builtin_huge_valf128() ((_Float128) __builtin_huge_val ()) # endif @@ -96,7 +103,7 @@ typedef __float128 _Float128; Converting a narrower sNaN to _Float128 produces a quiet NaN, so attempts to use _Float128 sNaNs will not work properly with older compilers. */ -# if !__GNUC_PREREQ (7, 0) +# if !__GNUC_PREREQ (7, 0) && !defined __clang__ # define __builtin_copysignf128 __builtin_copysignq # define __builtin_fabsf128 __builtin_fabsq # define __builtin_inff128() ((_Float128) __builtin_inf ()) @@ -108,7 +115,7 @@ typedef __float128 _Float128; e.g.: __builtin_signbitf128, before GCC 6. However, there has never been a __builtin_signbitf128 in GCC and the type-generic builtin is only available since GCC 6. */ -# if !__GNUC_PREREQ (6, 0) +# if !__GNUC_PREREQ (6, 0) && !defined __clang__ # define __builtin_signbitf128 __signbitf128 # endif