From patchwork Tue Dec 17 17:36:24 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 103285 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0A68F3858C48 for ; Tue, 17 Dec 2024 17:37:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A68F3858C48 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=SPPm4aLn X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1792D3858D1E for ; Tue, 17 Dec 2024 17:36:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1792D3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1792D3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734456991; cv=none; b=dvLInrnZLidN1lIo74DuJy2XRDF9DPidSUi7sPz2J7LmgTQeGkCubivS3i5yrtATRkqaV9ByDv9u1BUIN3OlyoZRzV3CznvpeRd4nk2GxggjSbSTiTJW146XC03Pw/qs4jDwF9tUqZ+sUSyJgRfMsu2Nut2ZtzIvsjzvzqjmnUQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734456991; c=relaxed/simple; bh=tamv1ZYKfwPzoVQEfsZqD8GpFGwLh1b/He/p3QGBz7E=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=hn7RrNmV5CVxp32FQePTar8KUJlConMdKtkJj/uIYHdy+2YN9RrWdYdclSfdJ7jlj9pa9hEDzKZolFta+6jx2FjwSFQ4yZ+8XIEiIrIZNhH0TDpRcL0+GaS1HgZyX2e/uo4FQl7cID3YGPZXDkLTlwSTQldpKOZVcr2vRMilXiE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1792D3858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1734456990; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=ew/oXAb1WWSu6KrIMihfTrXv4pAlo9DcVrpj/HNHCzw=; b=SPPm4aLngSIF3RAJju65t+1gkmq4LLDFFQm4ago+5FpyjvoHpezUIq0LxtDfEOHBeJiLQI zTS97ANv6iUeOJL76SFFSdw5zb/vGQAOhu779rVGoKxOzJJV9lNIZ/DfDgE3qHGftlctcf IuXFSYEkD8+XGNMfekQAMczwPdzOiEc= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-BppelgywMFGbfBMex6Y7DQ-1; Tue, 17 Dec 2024 12:36:29 -0500 X-MC-Unique: BppelgywMFGbfBMex6Y7DQ-1 X-Mimecast-MFC-AGG-ID: BppelgywMFGbfBMex6Y7DQ Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AEB2F195609D for ; Tue, 17 Dec 2024 17:36:28 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.21]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DC8EE19560A2 for ; Tue, 17 Dec 2024 17:36:27 +0000 (UTC) From: Florian Weimer To: libc-alpha@sourceware.org Subject: [PATCH] x86: Avoid integer truncation with large cache sizes (bug 32470) Date: Tue, 17 Dec 2024 18:36:24 +0100 Message-ID: <87seqmrz3b.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: YGB0-3zmsf7-7FB3nUWv62Yu2-PRqQFoK-cRAbptblo_1734456988 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patchwork=sourceware.org@sourceware.org Some hypervisors report 1 TiB L3 cache size. This results in some variables incorrectly getting zeroed, causing crashes in memcpy/memmove because invariants are violated. Tested on i686-linux-gnu and x86_64-linux-gnu on bare metal, and on x86_64-linux-gnu with bhyve reporting 1 TiB of L3 cache. --- sysdeps/x86/dl-cacheinfo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: 87cd94bba4091d22e24116298ade33b712ada235 diff --git a/sysdeps/x86/dl-cacheinfo.h b/sysdeps/x86/dl-cacheinfo.h index e9579505a3..6a0a30ba9d 100644 --- a/sysdeps/x86/dl-cacheinfo.h +++ b/sysdeps/x86/dl-cacheinfo.h @@ -1021,11 +1021,11 @@ dl_init_cacheinfo (struct cpu_features *cpu_features) non_temporal_threshold = maximum_non_temporal_threshold; /* NB: The REP MOVSB threshold must be greater than VEC_SIZE * 8. */ - unsigned int minimum_rep_movsb_threshold; + unsigned long int minimum_rep_movsb_threshold; /* NB: The default REP MOVSB threshold is 4096 * (VEC_SIZE / 16) for VEC_SIZE == 64 or 32. For VEC_SIZE == 16, the default REP MOVSB threshold is 2048 * (VEC_SIZE / 16). */ - unsigned int rep_movsb_threshold; + unsigned long int rep_movsb_threshold; if (CPU_FEATURE_USABLE_P (cpu_features, AVX512F) && !CPU_FEATURE_PREFERRED_P (cpu_features, Prefer_No_AVX512)) {