From patchwork Sat Oct 9 19:27:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Sebor X-Patchwork-Id: 46034 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9602A3858421 for ; Sat, 9 Oct 2021 19:28:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9602A3858421 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633807697; bh=3QN4IByB+6lcoHBuNw5SvHufEo3wy/C0IjicZGMlwU4=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=pv9caqfc6noTXtfbrKQpnuRfVYroMGdxV7GjM/r31EkJSx1i2OxyEBLrHpUuM8keQ oJxguujW/LUyq6K7E5CtUMpdekXdTiCI2Ye7Y9Kew5OMNTGqMTJDcn79kk/NB0XMve +kOSBlYnKYQCPf95DY3AB7y32JfMqMU0qlGIbNRY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by sourceware.org (Postfix) with ESMTPS id 968813858409 for ; Sat, 9 Oct 2021 19:27:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 968813858409 Received: by mail-qv1-xf33.google.com with SMTP id o13so8536692qvm.4 for ; Sat, 09 Oct 2021 12:27:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=3QN4IByB+6lcoHBuNw5SvHufEo3wy/C0IjicZGMlwU4=; b=XgpSEuKZJPO/d3KvHQrf9HWPDTpLysYKq0pIabXXAs7jhcsnNUFPQ468OqTJrKii17 5tAUbAls1ZmIa4N5odVMpXNVTMitaHcxTTCihAA1dJVafYErPV84OXZtBd6Sv22AKXAb ap2xnpRxfVNMB3L6iuB+Gs7OHz+B+e/04KRdZjk+CHxaW9/0PQG0wYSAtn3DYUhhK6U7 xkQL0J7aiXY0+tSFr1h/OPJ7cpuqhXGSSz4LF2UWzovn+ayfEH6sOIL7wypW5wOtzePX 9kV+uI+27GOlE6FtqJNK0aLQOh4soAiGdhO2pg3/Y1UBQBkVy30mAKIvdLoGvYY5kSkb ZiMw== X-Gm-Message-State: AOAM5314YSl4FXKC9/PpuLxUl/1EXr1aBVFVDurgraUligiN5g9IKJ7K R+dfdI6jxqn5LNBMGqI7UXyNlHqTuDo= X-Google-Smtp-Source: ABdhPJzkyOT7kapDguywJOIlEChEUlGK3zex9yAcPetqZkM9VuzQTF51uqwvV9QEVR7xR+C5udmz8Q== X-Received: by 2002:a05:6214:144c:: with SMTP id b12mr16711523qvy.56.1633807645082; Sat, 09 Oct 2021 12:27:25 -0700 (PDT) Received: from [192.168.0.41] (184-96-250-116.hlrn.qwest.net. [184.96.250.116]) by smtp.gmail.com with ESMTPSA id u129sm1796953qkd.127.2021.10.09.12.27.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Oct 2021 12:27:24 -0700 (PDT) To: GNU C Library Subject: [PATCH] replace sprintf with strcpy to avoid GCC warning [BZ#28439] Message-ID: <8bc40ccb-9d82-77c9-1277-cbff062b4ce6@gmail.com> Date: Sat, 9 Oct 2021 13:27:23 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 Content-Language: en-US X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Martin Sebor via Libc-alpha From: Martin Sebor Reply-To: Martin Sebor Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The patch below replaces a call to sprintf with an equivalent pair of strcpy calls to avoid a GCC false positive due to a recent optimizer improvement (still under review). I considered using #pragma GCC diagnostic but using strcpy here seems to me preferable than sprintf: thanks to the precondition check it's equally as safe but lighter-weight and no less readable. Tested on x86_64-linux running Fedora 29. Martin index 75b0e5f2f7..31ab1db60b 100644 --- a/resolv/res_query.c +++ b/resolv/res_query.c @@ -610,7 +610,9 @@ __res_context_querydomain (struct resolv_context *ctx, RES_SET_H_ERRNO(statp, NO_RECOVERY); return (-1); } - sprintf(nbuf, "%s.%s", name, domain); + strcpy (nbuf, name); + nbuf[n] = '.'; + strcpy (nbuf + n + 1, domain); } return __res_context_query (ctx, longname, class, type, answer, anslen, answerp, answerp2, nanswerp2,