From patchwork Mon Sep 25 08:19:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Tirta Halim X-Patchwork-Id: 76628 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6788A3857357 for ; Mon, 25 Sep 2023 08:23:16 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 78A273858CDA for ; Mon, 25 Sep 2023 08:23:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 78A273858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-690f9c787baso4214643b3a.1 for ; Mon, 25 Sep 2023 01:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695630181; x=1696234981; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jkbYdbnEvJqh4ez4YEX3oAlKGxQjpLRRFBDuDW2NKI8=; b=b5PZmXY0TWZgUif1Fra0q6AdJDBGZRNGWi2g4xbytjaRBneSdw4OzKMUixAuGOAFmF Re9yzJ25G/6WvJBERGFtxG40U0xahPaJuJK7//NVW/VTesHU7Qq27Vbvwi3Ky3xcrYMZ 6UimNZ3RZw2CQ27B5KoR0LlZCzdsUEFW+6kmA2WJ9q41z9b3FKY+N1MrGmD2RBWxOWmF M0Xz5BCcyEeSlUc/ABfxXTvzC+bJMko6yvGKBy90cpVM48RXBBFnrhdjRFkq8Vkllm45 LjK6ej5VjDuZ6V8x9+mrv6EQjrzd90BXfhLzwFG+QteKoaFX9o8CqnQNwyRz3JRN4USx JQmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695630181; x=1696234981; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jkbYdbnEvJqh4ez4YEX3oAlKGxQjpLRRFBDuDW2NKI8=; b=LGhxZ7KLdvsjYBtVs8KnbYPEU/KFdJGXZBlEM1N5BBnFu2mYXXvh2N4MVAaP3qMY+l SUv5m3rHmyewufVYHUluJK+lMhMEcsvdBCj0korErbIjSgSQkTUT2MpJRIrJVlmDOEvw 2WZzz96wvLLLdXSbsFB7Jk/b94uQBkB3O/V9xmwqfdxX7ONpIWAH2SIT/q7KHBSepxzs a48V+1TBBjtTUpF5V7FcgfJowY8qa/V4On4HHJ4+ksp+6X7KslaRs6P6E+AzmLU29gfI QKPYgw+tRYLdfNWp7AK2KMPfwIVFsrsiqJ9rImbf7pzQs4FW+4vUqjs0oCc6AYW0ug+G EhRA== X-Gm-Message-State: AOJu0Yw+tIwePB5HAJSI30l3fyzLCzUex429bYdROYeAi+WHHpIZrzIV o0zhLSrr9neaxPfpxJixlKLxFmzoDZnpzTI4 X-Google-Smtp-Source: AGHT+IH2SeOUtzRQjUXB52aw9vL8a5VBkDNTxolG/iN8ZDIu8wzLYefChA5dDHQmbEcZXYu8+78YOw== X-Received: by 2002:a05:6a20:7489:b0:153:8183:2917 with SMTP id p9-20020a056a20748900b0015381832917mr4814562pzd.21.1695630180597; Mon, 25 Sep 2023 01:23:00 -0700 (PDT) Received: from localhost.localdomain ([2001:448a:20a0:8e97:e977:ed1e:d425:86dd]) by smtp.gmail.com with ESMTPSA id h8-20020a170902748800b001b895336435sm1851574pll.21.2023.09.25.01.22.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 01:23:00 -0700 (PDT) From: James Tirta Halim To: libc-alpha@sourceware.org Cc: James Tirta Halim Subject: [PATCH] ftw.c: strchr(s, '\0') isn't always optimized to s + strlen(s) Date: Mon, 25 Sep 2023 15:19:25 +0700 Message-ID: <20230925081925.81343-1-tirtajames45@gmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org --- io/ftw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/io/ftw.c b/io/ftw.c index 742369a2d2..533b4012e5 100644 --- a/io/ftw.c +++ b/io/ftw.c @@ -554,7 +554,7 @@ fail: /* Next, update the `struct FTW' information. */ ++data->ftw.level; - startp = strchr (data->dirbuf, '\0'); + startp = data->dirbuf + strlen(data->dirbuf): /* There always must be a directory name. */ assert (startp != data->dirbuf); if (startp[-1] != '/') @@ -595,7 +595,7 @@ fail: while (result == 0 && *runp != '\0') { - char *endp = strchr (runp, '\0'); + char *endp = runp + strlen(runp); // XXX Should store the d_type values as well?! result = process_entry (data, &dir, runp, endp - runp, DT_UNKNOWN);