From patchwork Mon Jul 12 08:26:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 44311 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7FF273836017 for ; Mon, 12 Jul 2021 08:27:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7FF273836017 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1626078448; bh=46b+NcCvxRJcdiCyEDluXp4ISsACRiJwq6JdA42OVYs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=stcELOtTuLPGCF+PfVgCBGlGnUCMoC0JnmI6zqDzkMnM2/2juz/d9HlKionO2xzw1 QmvVp1qmnt9Ku1BySNxhZIqbJQX96FidRkOgZmT7bNZxmy7n4uL3g5MJXYLuwzt1dG DBC23W/c+QM18wKNxZXKrubOGpErHpbengJ+lKFY= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id A26553857807 for ; Mon, 12 Jul 2021 08:27:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A26553857807 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-144-8CfYOpDsMnexcm7tF7hDCQ-1; Mon, 12 Jul 2021 04:27:02 -0400 X-MC-Unique: 8CfYOpDsMnexcm7tF7hDCQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA320A0CB0; Mon, 12 Jul 2021 08:27:01 +0000 (UTC) Received: from oldenburg.str.redhat.com (ovpn-112-103.rdu2.redhat.com [10.10.112.103]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6CDD31A86F; Mon, 12 Jul 2021 08:27:00 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] libgomp: Include early to avoid link failure with glibc 2.34 Date: Mon, 12 Jul 2021 10:26:47 +0200 Message-ID: <87bl78djjs.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Cc: libc-alpha@sourceware.org Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" is included indirectly in the #pragma GCC visibility hidden block. With glibc 2.34, needs a declaration of the sysconf function, and including it under hidden visibility turns other calls to sysconf into hidden references, leading to a linker failure. libgomp/ChangeLog: * libgomp.h: Include . --- libgomp/libgomp.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libgomp/libgomp.h b/libgomp/libgomp.h index 8d25dc8e2a8..1fe209429d1 100644 --- a/libgomp/libgomp.h +++ b/libgomp/libgomp.h @@ -46,6 +46,7 @@ #include "libgomp-plugin.h" #include "gomp-constants.h" +#include #ifdef HAVE_PTHREAD_H #include #endif