From patchwork Sun Aug 7 12:00:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lv Ying X-Patchwork-Id: 56583 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 76589385783E for ; Sun, 7 Aug 2022 12:00:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76589385783E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659873640; bh=Ni503YLIXeBZQ1NsQVh/SFs5LsAF9fiQBOyO7LRkE9g=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=OKJmsno27CtN25zbW2dRlFzHJ5Pi9RuCqcgI5b26jHe5wB9ldcNisdRjt68YMDods Eirt/GZ75ZL3uKVGcZH7Qsw7Xmd4UWpyNzjjjTnUwXN9teYtfu+uGqeHbxHYAOxd/q tJBUeL9Oo0NtUXi4KqBklJi6wrNf9yu2TGd4Qoi0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 640033857427 for ; Sun, 7 Aug 2022 12:00:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 640033857427 Received: by mail-pl1-x634.google.com with SMTP id o3so6315406ple.5 for ; Sun, 07 Aug 2022 05:00:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ni503YLIXeBZQ1NsQVh/SFs5LsAF9fiQBOyO7LRkE9g=; b=WIGCWwORlLfkm7zHtakHD8QTOQrL/hGsz+kZ0IMb2Viya0K+XBir1wvO0LGz+p8pUc u0kKiTZeCZvi2yaAdBdgoeZI5ZxRc83YrBS/1rKVQwt5bxuLaythbKutAV7aJZThbofq SNGofad1KXXnM71F6FBGLgL36X27RTiAecAA55wPM4Cw1O95J2qJYOLEkLVvc9RCcAT2 CX6kqnW1x5cPT+5pNe6LlJuhsfCgo+6oWZBTehgBvI1KEMxmtCOA34cAHf6F4i8tMdKr gasiTnClpG5k/E+sROIXYjhkBnEzdH3fwIWSE4p6wpH+YD7eFQZ6tzUWaC5vm19z0ZXb 0RsA== X-Gm-Message-State: ACgBeo0lN49igYCM4++Uu2G92ULiSlT0dY6+Sa7SngYVrmOrHV3ktE8E hRScKXLb+kSACedex1CnLEJmkcdFi4YJuA== X-Google-Smtp-Source: AA6agR7zvFAU6bgQVj/Q8AL/AAKu1z9BhLLXmmvdbSczE3XMsqSnlnH/GL+eLf1C9v/vLxBkpI+qvg== X-Received: by 2002:a17:902:6b4b:b0:16e:ef21:5664 with SMTP id g11-20020a1709026b4b00b0016eef215664mr14377020plt.122.1659873616846; Sun, 07 Aug 2022 05:00:16 -0700 (PDT) Received: from 192.168.247.129 ([212.107.28.24]) by smtp.gmail.com with ESMTPSA id 19-20020a170902c21300b0016be368fb30sm6389294pll.212.2022.08.07.05.00.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 05:00:16 -0700 (PDT) To: libc-alpha@sourceware.org, fweimer@redhat.com Subject: [RFC] elf: fine-grained output LD_DEBUG log when symbol lookup error Date: Sun, 7 Aug 2022 05:00:03 -0700 Message-Id: <20220807120003.313131-1-lvying.system.thoughts@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Lv Ying via Libc-alpha From: Lv Ying Reply-To: Lv Ying Cc: lvying6@huawei.com, Lv Ying Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" When LD_DEBUG environment variable is set except "unused" value, symbol lookup error in _dl_lookup_symbol_x will output unrelated debugging information which mess up the "files" "libs" "reloc" log. "undefined symbol" debugging information should only output when LD_DEBUG="symbols|all". --- elf/dl-lookup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elf/dl-lookup.c b/elf/dl-lookup.c index 4c86dc694e..6085c6c90c 100644 --- a/elf/dl-lookup.c +++ b/elf/dl-lookup.c @@ -781,7 +781,7 @@ _dl_lookup_symbol_x (const char *undef_name, struct link_map *undef_map, if (__glibc_unlikely (current_value.s == NULL)) { if ((*ref == NULL || ELFW(ST_BIND) ((*ref)->st_info) != STB_WEAK) - && !(GLRO(dl_debug_mask) & DL_DEBUG_UNUSED)) + && (GLRO(dl_debug_mask) & DL_DEBUG_SYMBOLS)) { /* We could find no value for a strong reference. */ const char *reference_name = undef_map ? undef_map->l_name : "";