From patchwork Fri Jul 22 16:27:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Cristian_Rodr=C3=ADguez?= X-Patchwork-Id: 56274 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F29FD38356B1 for ; Fri, 22 Jul 2022 16:27:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F29FD38356B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1658507264; bh=Ug9WWW+Vc0EKatFWFa+ACwevy9CzBzbvDVN+CsSwmpQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=aD6kGdyy2eTQ9qC6UYdCdwMcwiFKDobjfSrV7FZU75evmg2186q8EhDp3nsX7QRlO jysEHo8pWTHuM0CKP3fadp5yEpaQJscoqqLHg4GQ+UmxWvbztt+KKN4wmo1HEFzCb5 uDtbnpiDviPZVcfYckklMv1KwFZBI5Q542pWb6t0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by sourceware.org (Postfix) with ESMTPS id 5B1533857C5D for ; Fri, 22 Jul 2022 16:27:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B1533857C5D Received: by mail-ot1-f47.google.com with SMTP id l9-20020a056830268900b006054381dd35so3709543otu.4 for ; Fri, 22 Jul 2022 09:27:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ug9WWW+Vc0EKatFWFa+ACwevy9CzBzbvDVN+CsSwmpQ=; b=Y9dT6SwcepqbpF00uCqRdZRifD2WvjkxaYd13zVMCWwwn2N4ogbzyYK1Tv8atn0yek 9OtdkmrMpOwVlOpwvGh6iv/KB9XTt4CnQnuje1Fb3vRaucgombSg2vToTw+ZoFu5sDF0 bNO2qJLW02wONnx0CJYYykiDU7CyDvPN9SmHvP/Qo03i6AFESbNI0iiwfeoi3GIS6XDy 3l5FeU46sWUamE9Az8xQu0xVwfgFNLYRhXgi9dDsLEh8cQMJDco0KoRMHooErnYDrrBr MQ/AOIQSbJBy4A2HJlKdsqFnp+sr5N4sOjJLTZBMPcWRtLnZQtwlHcpOG9HUCWIdaiBK 8pdQ== X-Gm-Message-State: AJIora+zGtVZjDqiUg5GUAp9qQG/x/WKog32908qxD6aFENuv9GuvdPd gMh7LJt57uzl8hyKZHL9NCWxpsOZ9dM= X-Google-Smtp-Source: AGRyM1s3vD2BPxazFcQcXW3m07bsvxw7l27V2/SjjjhfTjt+a9kUqPPtb602BucFNuLtDg5CZBp+Aw== X-Received: by 2002:a05:6830:1f49:b0:61c:9e6b:a73a with SMTP id u9-20020a0568301f4900b0061c9e6ba73amr281634oth.105.1658507241429; Fri, 22 Jul 2022 09:27:21 -0700 (PDT) Received: from tumbleweedvm.. ([181.160.1.56]) by smtp.gmail.com with ESMTPSA id k23-20020a4ad117000000b004359b581401sm2023938oor.25.2022.07.22.09.27.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Jul 2022 09:27:20 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH] resolv: use arc4random_uniform in the generation of random ids Date: Fri, 22 Jul 2022 16:27:15 +0000 Message-Id: <20220722162715.30625-1-crrodriguez@opensuse.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Cristian_Rodr=C3=ADguez_via_Libc-alpha?= From: =?utf-8?q?Cristian_Rodr=C3=ADguez?= Reply-To: =?utf-8?q?Cristian_Rodr=C3=ADguez?= Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" In the context of DNS it is important to have highest possible quality ids. Signed-off-by: Cristian Rodríguez --- resolv/res_mkquery.c | 4 ++-- resolv/res_randomid.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/resolv/res_mkquery.c b/resolv/res_mkquery.c index 5bc5b41531..ee161a8d95 100644 --- a/resolv/res_mkquery.c +++ b/resolv/res_mkquery.c @@ -91,9 +91,9 @@ #include #include #include +#include #include #include -#include int __res_context_mkquery (struct resolv_context *ctx, int op, const char *dname, @@ -116,7 +116,7 @@ __res_context_mkquery (struct resolv_context *ctx, int op, const char *dname, /* We randomize the IDs every time. The old code just incremented by one after the initial randomization which still predictable if the application does multiple requests. */ - hp->id = random_bits (); + hp->id = res_randomid (); hp->opcode = op; if (ctx->resp->options & RES_TRUSTAD) hp->ad = 1; diff --git a/resolv/res_randomid.c b/resolv/res_randomid.c index fb1fa17539..f5f5afd0cd 100644 --- a/resolv/res_randomid.c +++ b/resolv/res_randomid.c @@ -84,10 +84,10 @@ #include #include -#include +#include unsigned int res_randomid (void) { - return 0xffff & random_bits (); + return arc4random_uniform (UINT16_MAX); } libc_hidden_def (__res_randomid)