X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Virus-Scanned: amavisd-new at neurotica.com
X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=neurotica.com; s=mail;
	t=1608750112; bh=BiV8gFTwQczl5rBy+yZRdyiEj+EbBppw9J7k1/CVXqs=;
	h=To:From:Subject:Date;
	b=FAVyPamsnVvkyFmcALtNrDCgQkYRk+Pz8dz05T1sbEnYy4/z0VkqqwJAsVufdbatE
	 10H2tqEtvYnbSIcGDPK2XasbwKTaS4PpBZpD9QgVUlhizqBUwuvTfs8MGAEdlt4fSI
	 thP/fZaIJFqVlPBlrVcdznbv8lifN1fRZ52viW+JliM+HTvuNXon7i2LOblLQbgGFi
	 Os6IMlAWYkDzmRF8bNBAJv9QVPARClLKeNTZLCFf/tzSdrHy/l1HvpG14RALWJWXWf
	 r4OQYI67VnPUQ4/673nUSYgnZsRVc+lh4MVpacg/uXbwXzPizvJxIycf1FkkBVTv2O
	 uxwsWdVb0ZBTg==
To: geda-user AT delorie DOT com
From: "Dave McGuire (mcguire AT neurotica DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
Subject: [geda-user] 1.10.2 build failure
Message-ID: <a36ff184-32ca-c283-2da3-8207ca051b52@neurotica.com>
Date: Wed, 23 Dec 2020 14:01:52 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Reply-To: geda-user AT delorie DOT com


   Hi folks, building 1.10.2 I just hit this compilation error:

-------------------------------------
x_event.c:110:7: error: 'unsnapped_wx' may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
    w_x = snap_grid (w_current, unsnapped_wx);
        ^
x_event.c:84:7: note: 'unsnapped_wx' was declared here
    int unsnapped_wx, unsnapped_wy;
        ^
x_event.c:111:7: error: 'unsnapped_wy' may be used uninitialized in this 
function [-Werror=maybe-uninitialized]
    w_y = snap_grid (w_current, unsnapped_wy);
        ^
x_event.c:84:21: note: 'unsnapped_wy' was declared here
    int unsnapped_wx, unsnapped_wy;
                      ^
lto1: some warnings being treated as errors
-------------------------------------

   The platform in use is Linux Mint v19.3.

   I was able to continue the build by removing 
-Werror=maybe-uninitialized from gschem/src/Makefile, but that doesn't 
seem like the right solution. ;)

   Briefly perusing the source, following that variable as it's passed 
from function to function lead me to gschem/src/gschem_page_view.c where 
that variable is explicitly assigned, so the code does look safe.

   Another such error happens in gattrib/src/gtksheet_2_2.c, the same 
Makefile edit in that directory gets around it.

   This build results in functional binaries, though I've not done much 
testing.

                -Dave

-- 
Dave McGuire, AK4HZ
New Kensington, PA