X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-CMAE-Analysis: v=2.4 cv=ZIsSJV3b c=1 sm=1 tr=0 ts=5fc5a161 a=+cj0cO56Fp8x7EdhTra87A==:117 a=/1sP3ydGdgxMRE5jqSvsHw==:17 a=9+rZDBEiDlHhcck0kWbJtElFXBc=:19 a=IkcTkHD0fZMA:10 a=nNwsprhYR40A:10 a=a1KZgU7cAAAA:8 a=Mj1Xp5F7AAAA:8 a=2XxB4mUaAAAA:20 a=TFgBoBdjGM4_DPPY8XAA:9 a=QEXdDO2ut3YA:10 a=ng0hpkU2jXKPaRTLMVYJ:22 a=OCttjWrK5_uSHO_3Hkg-:22 X-SECURESERVER-ACCT: glimrick AT epilitimus DOT com Subject: Re: [geda-user] SAB processing patches To: geda-user AT delorie DOT com References: <6fb9f8e7-6a21-308e-0fa6-58ca11bd166f AT epilitimus DOT com> From: "Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com]" Message-ID: <449000ed-57b7-ccad-b1aa-0fb9ce5a8b19@epilitimus.com> Date: Mon, 30 Nov 2020 17:50:13 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0 SeaMonkey/2.53.3 MIME-Version: 1.0 In-Reply-To: <6fb9f8e7-6a21-308e-0fa6-58ca11bd166f@epilitimus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - a2plcpnl0121.prod.iad2.secureserver.net X-AntiAbuse: Original Domain - delorie.com X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - epilitimus.com X-Get-Message-Sender-Via: a2plcpnl0121.prod.iad2.secureserver.net: authenticated_id: glimrick AT epilitimus DOT com X-Authenticated-Sender: a2plcpnl0121.prod.iad2.secureserver.net: glimrick AT epilitimus DOT com X-Source: X-Source-Args: X-Source-Dir: X-CMAE-Envelope: MS4xfHHfmCgbZm1VRWs9SVjh0uJt8QZd8OkBJnJs2HajvJbgz71QzmdvEBYJDHtqP1WGZPnF8/yR7po6fMn1HPf3x+cA3q3aneSiOmcTVsiWz/qPfAgAKtxq +jXB7XWlZ1Xm2J9ZQnigcbK2UOZ4nCwPtQMaqZNebIvkG6YjCuU5RuQY8mdnMLh9FAay6fhokTs4ShxKEqVExI3OkRKYj3lTgkSGjHlxZaMl3ZjCR6mUAU/1 Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk Added another patch to the bug report to fix at least a sizeable chunk of these formatting issues. Had to do some of it twice because I messed up... So I may have missed something I found the first time. Glenn Glenn (glimrick AT epilitimus DOT com) [via geda-user AT delorie DOT com] wrote: > Roland, > > Roland Lutz wrote: >> Hi Glenn, >> >> On Mon, 30 Nov 2020, Glenn (glimrick AT epilitimus DOT com) [via >> geda-user AT delorie DOT com] wrote: >>> Just posted the patches to add SAB processing to geda/gaf as Bug >>> #1906297. >> that's an interesting series of patches!  I took the liberty of >> uploading them to Github for easier reference: >> >>     https://github.com/rlutz/geda-gaf/commits/glenn-sab >> >>> From a first glance, this looks good.  I'll have to go through the >>> patches >> and understand how they work in detail in order to say anything >> substantiated, but there's some formal things I noticed when skimming >> through: >> >> - Functions which are only used inside the file in which they are >> defined should be "static" (not visible in the global namespace). >> >> - New C code should follow the C coding style of the project: >>   - two spaces indentation, >>   - one space character before a parameter list(!) and before and >> after an >>     operator, and before (but not after) a pointer asterisk, >>   - the opening brace goes on the same line for control structures but on >>     a separate line for function headers. >>   Code on one level of indentation should always be indented >> consistently. >> >> - The Python code formatting looks good, but here, too, a space >> character should go before and after operators. >> >> - Your patches contain whitespace errors (trailing whitespace, missing >> or extra newline characters at the end of the file).  You can check >> your commits with ``git diff-tree --check master..''. >> >> - Lines in source and text files should be less than 80 characters >> long. Lines in commit messages should not be longer than 72 >> characters, and (if one feels pedantic) 64 characters on the first line. >> >> - You don't have to list the files you touched in the commit message. > As much for my reference as anything else. It should make is simpler to > fix all the above :) >> Don't let yourself discourage by this!  These are just conventions.  >> I'll give you more detailed feedback as soon as I find time. >> >> Roland >> >> > I'll start working my way through these. > Glenn > >