X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=prochac.sk; s=default; t=1453047237; bh=uRCuzgKjbPxPO7/ICjLwvEjK9/zE7lbhYXoefGd4XZk=; h=Subject:To:References:From:Date:In-Reply-To; b=TlAMAO1gJFu92lJjf+NKBkryfFRjAjkuniWp3q5xjqaucSry/3tFLvQtypZf65lM2 eegW9sHll0qLPhWiLJqRWvRdgeRDSdgdec4QawH7is9oHqtVoDrM2sl9naw7XkuXUQ 0jjWchqVNOGgWTYGK5XWPFGr8zJVfLGtoZmzPg0E= X-Clacks-Overhead: "GNU Terry Pratchett" Subject: Re: [geda-user] cleaner version of fixes to file format plugin To: geda-user AT delorie DOT com References: From: "Milan Prochac (milan AT prochac DOT sk) [via geda-user AT delorie DOT com]" Message-ID: <569BBE0A.3060407@prochac.sk> Date: Sun, 17 Jan 2016 17:15:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------020203080205080903060406" X-Spam-Status: No, score=-101.0 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE, USER_IN_WHITELIST autolearn=ham autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on angua.bastl.sk Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk This is a multi-part message in MIME format. --------------020203080205080903060406 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 17. 1. 2016 13:24, Peter Clifton (petercjclifton AT googlemail DOT com) [via geda-user AT delorie DOT com] wrote: > No // comments please. > These was just missed durin cleanup, these lines were supposed to be deleted. it's already cleaned (I use // comments as simplest way to mark code to be deleted) > is_default - is that supposed to be a boolean, or a number? > Already changed to bool... > If boolean - don't use int :) > > (Not a comprehensive code-review... I already said, I don't have time > for this until the code-sprint after FOSDEM). > and lot of other changes ... including code formatting Milan > Peter > > On 17 January 2016 at 00:34, Britton Kerin (britton DOT kerin AT gmail DOT com > ) [via geda-user AT delorie DOT com > ] > wrote: > > > The attached diff is against the version bert checked in but it > lacks introduced bugs and most irrelevant junk. > > I also pushed it to LP1532611_fixes > > --------------020203080205080903060406 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by angua.bastl.sk id u0HGDvww020441
On 17. 1. 2016 13:24, Peter Clifton (petercjclifton AT googlemail DOT com) [via geda-user AT de= lorie.com] wrote:
No // comments please.


These was just missed durin cleanup, these lines were supposed to be deleted. it's already cleaned (I use // comments as simplest way to mark code to be deleted)

is_default - is that supposed to be a boolean, or a number?


Already changed to bool...

If boolean - don't use int :)

(Not a comprehensive code-review... I already said, I don't have time for this until the code-sprint after FOSDEM).


and lot of other changes ...=C2=A0 including code formatting

Milan

Peter

On 17 January 2016 at 00:34, Britton Kerin (britton DOT kerin AT gmail DOT c= om) [via geda-user AT delorie DOT com] <ged= a-user AT delorie DOT com> wrote:

The attached diff is against the version bert checked in but it lacks introduced bugs and most irrelevant junk.

I also pushed it to=C2=A0LP1532611_fixes


--------------020203080205080903060406--