X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com X-Virus-Scanned: Debian amavisd-new at papyrus.altaweb.hu Date: Wed, 6 Jan 2016 19:24:11 +0100 From: "Lev (leventelist AT gmail DOT com) [via geda-user AT delorie DOT com]" To: geda-user AT delorie DOT com Subject: Re: [geda-user] Merging stuff. How to make it happen Message-ID: <20160106192411.7d9fd782@jive.levalinux.org> In-Reply-To: References: X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; amd64-portbld-freebsd10.1) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by delorie.com id u06IOK3m022866 Reply-To: geda-user AT delorie DOT com Errors-To: nobody AT delorie DOT com X-Mailing-List: geda-user AT delorie DOT com X-Unsubscribes-To: listserv AT delorie DOT com Precedence: bulk On Mon, 4 Jan 2016 02:12:34 +0000 "Peter Clifton (petercjclifton AT googlemail DOT com) [via geda-user AT delorie DOT com]" wrote: > I'm probably starting to run out of energy for tonight, having got > chatting on IRC... > > Before I get started, I'm probably going to pick out some areas, and > quote project "rules" which I'm sure I've broken myself at one time > or other, either inadvertently, deliberately, or out of laziness! - > Bear that in mind if you think I'm being unfair... > > What I would also say though, is that I do very much try to hold > myself to these rules, as I did when I was working on gEDA, and PCB > far more actively. > > > Some general themes which I'll not drag up for individual patches... > > "//" comments are not PCB style. > Nor is "if () {" in the core... it is: > > if (condition) > { > code(); > more_code(); > } Should we setup astyle to do the right thing? http://astyle.sourceforge.net/ -- 73 de HA5OGL Op.: Levente