X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f X-Recipient: geda-user AT delorie DOT com DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=lavabit; d=nerdshack.com; b=xDZSD7H82gcpl+6sh46qIOhu1x58oLLl0OJWVcEw0mGn0HTuiHB/PeO3/MeDJKJvzlNwdon5qRFmXO+VoZxqmqgcOT0qJnqTC6lweP/VfDE206ju3Z/kp3AN66MPaMszCT/EsV18MV9LKhVwOj/OgSVUnwhiE2l993ujn0rL4Ao=; h=Date:From:To:Subject:Message-ID:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding; Date: Wed, 24 Jul 2013 16:45:22 +0600 From: Alexey Shaposhnikov To: geda-user AT delorie DOT com Subject: [geda-user] Redundant drawing functions in libgedacairo Message-ID: <20130724164522.311d7f3d@warrawoona.sti> X-Mailer: Claws Mail 3.9.2 (GTK+ 2.24.20; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by delorie.com id r6OAjYjO008630 Reply-To: geda-user AT delorie DOT com While hacking libgeda i found, that functions eda_renderer_draw_line, eda_renderer_draw_net, eda_renderer_draw_bus and eda_renderer_draw_pin in libgedacairo actually repeat each other. The only difference is that the first function takes the values for ​​line width, cap style, dash style and dash length from object properties, while others use a hard-coded values (despite all those properties can be set while creating pin, bus or net object). Did i miss something? -- With best regards, Alexey Shaposhnikov.