X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Sat, 17 Mar 2012 13:14:11 -0700
From: Andrew Poelstra <asp11 AT sfu DOT ca>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] very old .pcb file
Message-ID: <20120317201411.GD31669@malakian.lan>
References: <alpine DOT DEB DOT 2 DOT 00 DOT 1203150341280 DOT 15144 AT zaphod DOT 661 DOT org>
 <20321 DOT 59968 DOT 314778 DOT 216654 AT vagabond DOT local>
 <alpine DOT DEB DOT 2 DOT 00 DOT 1203161149570 DOT 8944 AT zaphod DOT 661 DOT org>
 <20120316194917 DOT GA28072 AT malakian DOT lan>
 <CAOxVtSQ1VSvMxXePObD3G++EX0NsBC=LxjV+LjfX5D9o3tcv=w AT mail DOT gmail DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAOxVtSQ1VSvMxXePObD3G++EX0NsBC=LxjV+LjfX5D9o3tcv=w@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Sat, Mar 17, 2012 at 04:07:35PM +0300, Sergey Alyoshin wrote:
> 2012/3/16 Andrew Poelstra <asp11 AT sfu DOT ca>:
> > Or maybe somebody has already fixed it? I have not checket git HEAD
> > in a month or so.
> 
> With following patch, file http://661.org/tmp/ramcard.pcb can be
> opened in pcb from git.
> Is it acceptable?
> 
> diff --git a/src/parse_y.y b/src/parse_y.y
> index 2ae9f6c..22d02cc 100644
> --- a/src/parse_y.y
> +++ b/src/parse_y.y
> @@ -863,6 +863,8 @@ layer
> 
>  					/* memory for name is already allocated */
>  				Layer->Name = $4;
> +				if (Layer->Name == NULL)
> +					Layer->Name = strdup("");
>  				LayerFlag[$3-1] = true;
>  				if (yyData->LayerN + 2 < $3)
>  				  yyData->LayerN = $3 - 2;

Thanks for the patch Sergey. :)

I have applied it as commit 4bc7ae3823b8120fdf415ee17ca7726fab5c8dcf



DJ, it appears that the commit pushed successfully, but the commit
robot seems to have crashed:

titanic ~/Code/pcb$ git push
Enter passphrase for key '/home/username/.ssh/id_pcb': 
Counting objects: 7, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 661 bytes, done.
Total 4 (delta 3), reused 0 (delta 0)
remote: Traceback (most recent call last):
remote:   File "/geda/commit_robot/commit_robot_post-receive.py", line 471, in <module>
remote:     sys.exit(main())
remote:   File "/geda/commit_robot/commit_robot_post-receive.py", line 350, in main
remote:     db = robot_db(robot_db_file)
remote:   File "/geda/commit_robot/commit_robot_post-receive.py", line 126, in __init__
remote:     self._dbcon = sqlite3.connect(self._dbfile, timeout=0, isolation_level=None)
remote: sqlite3.OperationalError: unable to open database file
To ssh://pcb/pcb.git
   a044f40..4bc7ae3  master -> master


-- 
Andrew Poelstra
Email: asp11 at sfu.ca OR apoelstra at wpsoftware.net
Web:   http://www.wpsoftware.net/andrew
"You shouldn't trust every quote you read on the Internet." -- Socrates