X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
Date: Sat, 17 Mar 2012 11:25:58 -0700
From: Andrew Poelstra <asp11 AT sfu DOT ca>
To: geda-user AT delorie DOT com
Subject: Re: [geda-user] very old .pcb file
Message-ID: <20120317182558.GA31669@malakian.lan>
References: <alpine DOT DEB DOT 2 DOT 00 DOT 1203150341280 DOT 15144 AT zaphod DOT 661 DOT org>
 <20321 DOT 59968 DOT 314778 DOT 216654 AT vagabond DOT local>
 <alpine DOT DEB DOT 2 DOT 00 DOT 1203161149570 DOT 8944 AT zaphod DOT 661 DOT org>
 <20120316194917 DOT GA28072 AT malakian DOT lan>
 <CAOxVtSQ1VSvMxXePObD3G++EX0NsBC=LxjV+LjfX5D9o3tcv=w AT mail DOT gmail DOT com>
 <201203171716 DOT q2HHGKBO032473 AT envy DOT delorie DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201203171716.q2HHGKBO032473@envy.delorie.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com
Precedence: bulk

On Sat, Mar 17, 2012 at 01:16:20PM -0400, DJ Delorie wrote:
> 
> > With following patch, file http://661.org/tmp/ramcard.pcb can be
> > opened in pcb from git.
> > Is it acceptable?
> 
> Would it be better to make up a name, like "Layer%d" ?
>
 
The source file has the layer name as "", so to avoid modifying
it unnecessarily, I think we should keep the layer name as "".

> Are we sure strdup() is the right thing to do?

I believe the answer is yes:

In mymem.c:721, when cleaning up pcb data, we call free() on the layer
name. So presumably the name should either be NULL, or memory that we
allocated.

-- 
Andrew Poelstra
Email: asp11 at sfu.ca OR apoelstra at wpsoftware.net
Web:   http://www.wpsoftware.net/andrew
"You shouldn't trust every quote you read on the Internet." -- Socrates