X-Authentication-Warning: delorie.com: mailnull set sender to djgpp-workers-bounces using -f
Sender: rich AT phekda DOT freeserve DOT co DOT uk
Message-ID: <3C813341.C0D5B19B@phekda.freeserve.co.uk>
Date: Sat, 02 Mar 2002 20:17:05 +0000
From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
X-Mailer: Mozilla 4.77 [en] (X11; U; Linux 2.2.19 i586)
X-Accept-Language: de,fr
MIME-Version: 1.0
To: DJGPP workers <djgpp-workers AT delorie DOT com>
Subject: Re: Two small patches for the ported Fileutils 4.0
References: <2110-Sat02Mar2002181250+0200-eliz AT is DOT elta DOT co DOT il> <3C810999 DOT 5C1A775 AT phekda DOT freeserve DOT co DOT uk> <1659-Sat02Mar2002210230+0200-eliz AT is DOT elta DOT co DOT il>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Reply-To: djgpp-workers AT delorie DOT com

Hello.

Eli Zaretskii wrote:
> 
> > Date: Sat, 02 Mar 2002 17:19:21 +0000
> > From: Richard Dawe <rich AT phekda DOT freeserve DOT co DOT uk>
> > >
> > >   - ginstall would crash when invoked to install a file with no
> > >     extension (such as a shell script);
> >
> > Hmmm, that's pretty serious.
> 
> I wonder how come no one saw that before.  Are you guys even using
> "make install"?  Or do we have too few packages which install shell
> scripts?  (I saw this in Texinfo, which installs texi2dvi.)

Yes, I've used it a fair amount. When I'm preparing DJGPP packages I have a
'distribution make' area and a 'distribution test' area. To get from sources
to binaries, I unzip the source distribution into the 'test' area, then do a
'make install' from the 'test' to the 'make' area. So I should have caught
this problem at some point.

I'm pretty sure that I've used Fileutils to do a 'make install' on scripts -
glib 1.2.10 and XDelta 1.1.2 spring to mind. What platform did you find this
on? I'm using Windows 98 SE - perhaps this is hiding the bug for me. I did
test Fileutils under plain ol' DOS, but I did not test installing scripts with
ginstall AFAICR.

> > >   - "cp -Pp" would print an error message on filesystems that don't
> > >     allow setting timestamps of directories.
> > [snip]
> >
> > Well, I had said I don't think we need to suppress this message. But since
> > you've provided me with a patch and the current behaviour is inconsistent
> > with other parts of the Fileutils ports, I'll apply it. ;)
> 
> If we want the warning to appear on W2K and XP, the suppression could
> be conditioned on the OS version.
[snip]

Yes, I'll do that for Fileutils 4.1. I'd rather spend that effort on 4.1.

BTW Fileutils 4.1 is not far from alpha. I'm just trying to get the test suite
to work with DJGPP 2.03. I'm inclined to give up and just build it with DJGPP
CVS, since the test suite relies on symlinks a lot (ugh). Maybe if I have an
entire weekend free this month, I can get an alpha out.

Thanks, bye, Rich =]

-- 
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]