DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 581M03Jl3034185
DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 581M02gs3034155
From: Bogdan <bogdan AT mail DOT invalid>
Newsgroups: comp.os.msdos.djgpp
Subject: [PATCH] libao - use binary mode
Date: Mon, 1 Sep 2025 23:55:01 +0200
Organization: A noiseless patient Spider
Lines: 28
Message-ID: <10954nl$4ent$1@dont-email.me>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Injection-Date: Mon, 01 Sep 2025 21:55:01 +0000 (UTC)
Injection-Info: dont-email.me; posting-host="acee49b65b10e4994702d04bbcefc567";
	logging-data="146173"; mail-complaints-to="abuse AT eternal-september DOT org";	posting-account="U2FsdGVkX18bvGG4f6ooT5iPaiIAFEfX"
User-Agent: Mozilla Thunderbird
Cancel-Lock: sha1:mQLoqpY0quzNZKGGngYXID8lNh0=
Content-Language: en-GB, sv-SE, pl
Bytes: 1775
To: djgpp AT delorie DOT com
DJ-Gateway: from newsgroup comp.os.msdos.djgpp
Reply-To: djgpp AT delorie DOT com

Hello.

  While playing with the libao port, I noticed that WAV file output 
sounds bad. When comparing the output files (one from Linux, one from 
DOS), I saw the obvious - something which looked like a non-DOS 
newline was converted to a DOS newline, corrupting the output file.

  I've prepared a small patch that should fix the issue. Pasting it 
below. I hope I've done it correctly. No other suspicious places have 
been identified. The patch should actually fix all file output types.

  Thank you for your work on DJGPP, it's appreciated! :)


--- libao-1.2.0.orig/src/audio_out.c    2022-10-22 22:53:10.000000000 
+0200
+++ libao-1.2.0/src/audio_out.c 2025-09-01 22:57:28.603178971 +0200
@@ -1383,7 +1383,7 @@ ao_device *ao_open_file (int driver_id,
                 }


-               file = fopen(filename, "w");
+               file = fopen(filename, "wb");
         }