DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 61EJgd1o902597
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BBA14BAD151
MIME-Version: 1.0
Date: Sat, 14 Feb 2026 20:41:37 +0100
Message-ID: <CADt9575bV4TS0AAzcfDP=W1WgqUKEoDpLHUFQjx+5twuyzPdWw@mail.gmail.com>
Subject: BUG: "machine/types.h" not protected by multiple #include
To: The Cygwin Mailing List <cygwin AT cygwin DOT com>
From: "Carlo B. via Cygwin" <cygwin AT cygwin DOT com>
Reply-To: "Carlo B." <carlo DOT bramini AT gmail DOT com>
Content-Type: text/plain; charset="utf-8"
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>
Content-Transfer-Encoding: 8bit

Hello,
while compiling libsrtp2, I got this error:

/usr/include/machine/types.h:35:8: error: redefinition of ‘struct flock’
   35 | struct flock {
      |        ^~~~~
In file included from /usr/include/sys/types.h:222,
                 from
../gstreamer/subprojects/libsrtp-2.7.0/crypto/include/integers.h:60:
/usr/include/machine/types.h:35:8: note: originally defined here
   35 | struct flock {
      |        ^~~~~

This happens because into the library there is this code:

<--- CUT --->
#ifdef HAVE_SYS_TYPES_H
#include <sys/types.h>
#endif
#ifdef HAVE_MACHINE_TYPES_H
#include <machine/types.h>
#endif
<--- CUT --->

The first inclusion of "sys/types.h" includes also "machine/types.h"
and this is ok.
Next, the second directive includes again "machine/types.h" and here
it generates the error.
The problem comes out because "machine/types.h" has not a protection
against multiple inclusions. Actually, something like that should be
done on top and on the bottom of "machine/types.h", like I have seen
elsewhere on other libc:

#ifndef    _MACHTYPES_H_
#define    _MACHTYPES_H_
....
#endif /* _MACHTYPES_H_ */

By doing this change, everything will work properly because
"machine/types.h" won't try to declare again its types if it has been
already included. I don't know why libsrtp2 is doing this, perhaps it
is needed by other platforms.
However, I think that it should be quite easy to add this change and
make things more safe.

Sincerely,

Carlo Bramini.

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple