DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 55KBQitw2226900
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A83D388D792
MIME-Version: 1.0
References: <CAHnbEG+-vkWb3F9HJFNdtMt1wAtm90kz81p8H=0Y7QrGHn50ag AT mail DOT gmail DOT com>
 <aFFOZ0-JHbJKs1Fc AT calimero DOT vinschen DOT de>
In-Reply-To: <aFFOZ0-JHbJKs1Fc@calimero.vinschen.de>
Date: Fri, 20 Jun 2025 13:24:45 +0200
Message-ID: <CAHnbEGJCqd3cdB-Ky4-PbWzw=PSO7u7WKoL_t0boQotCGK5SfQ@mail.gmail.com>
Subject: Re: [PATCH][API-CONFORMAANCE] Increase SYMLOOP_MAX to 63
To: cygwin-patches AT cygwin DOT com, cygwin AT cygwin DOT com
Content-Type: multipart/mixed; boundary="00000000000035cb9e0637ff1e70"
From: Sebastian Feld via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Sebastian Feld <sebastian DOT n DOT feld AT gmail DOT com>
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

--00000000000035cb9e0637ff1e70
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 17, 2025 at 1:16=E2=80=AFPM Corinna Vinschen
<corinna-cygwin AT cygwin DOT com> wrote:
>
> Hi Sebastian,
>
> On Jun 17 09:48, Sebastian Feld wrote:
> > The following patch increases from 10 to 63, per Windows spec
> > https://learn.microsoft.com/en-us/windows/win32/fileio/reparse-points
> >
> > Security impact is minor, SYMLOOP_MAX is just an artificial limiter to
> > prevent endless loops.
>
> In case of Cygwin (Cygwin is slow, we all know that), the rather low
> SYMLOOP_MAX was chosen so the path handling didn't get even slower in
> some circumstances I don't remember anymore.  Maybe the times when this
> was relevant are over, so we can try this.

1. Cygwin is NOT slow. Who says that?
2. If there is a performance impact, then this should be documented in
the source code.

> However, please send a real git patch created with `git format-patch'
> and don't forget your Signed-off-by:".

Patch attached.

Are there CI or regression test scripts where I could add a test module?

Sebi
--=20
Sebastian Feld - IT security consultant

--00000000000035cb9e0637ff1e70
Content-Type: text/plain; charset="US-ASCII"; 
	name="0001-Increase-SYMLOOP_MAX-limit-to-63-per-Win32-spec.patch.txt"
Content-Disposition: attachment; 
	filename="0001-Increase-SYMLOOP_MAX-limit-to-63-per-Win32-spec.patch.txt"
Content-Transfer-Encoding: base64
Content-ID: <f_mc4q0s2t0>
X-Attachment-Id: f_mc4q0s2t0

RnJvbSBmN2ZjZWU4NWE2MDAxYTQyNTY5OTU0YTVjYzBmYWY5Y2JlZDdlZTA0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTZWJhc3RpYW4gRmVsZCA8c2ViYXN0aWFuLm4uZmVsZEBnbWFp
bC5jb20+CkRhdGU6IEZyaSwgMjAgSnVuIDIwMjUgMTM6MTk6MjMgKzAyMDAKU3ViamVjdDogW1BB
VENIXSBJbmNyZWFzZSBTWU1MT09QX01BWCBsaW1pdCB0byA2MyBwZXIgV2luMzIgc3BlYwoKSW5j
cmVhc2UgU1lNTE9PUF9NQVggbGltaXQgdG8gNjMgcGVyIFdpbjMyIHNwZWMuCgpUaGUgc3BlYyBh
dCBodHRwczovL2xlYXJuLm1pY3Jvc29mdC5jb20vZW4tdXMvd2luZG93cy93aW4zMi9maWxlaW8v
cmVwYXJzZS1wb2ludHMKc2F5czoKLi4uIFRoZXJlIGlzIGEgbGltaXQgb2YgNjMgcmVwYXJzZSBw
b2ludHMgb24gYW55IGdpdmVuIHBhdGguCk5PVEU6IFRoZSBsaW1pdCBjYW4gYmUgcmVkdWNlZCBk
ZXBlbmRpbmcgb24gdGhlIGxlbmd0aCBvZiB0aGUKcmVwYXJzZSBwb2ludC4gRm9yIGV4YW1wbGUs
IGlmIHlvdXIgcmVwYXJzZSBwb2ludCB0YXJnZXRzIGEgZnVsbHkKcXVhbGlmaWVkIHBhdGgsIHRo
ZSBsaW1pdCBiZWNvbWVzIDMxLiAqLwoKU2lnbmVkLW9mZi1ieTogU2ViYXN0aWFuIEZlbGQgPHNl
YmFzdGlhbi5uLmZlbGRAZ21haWwuY29tPgotLS0KIHdpbnN1cC9jeWd3aW4vaW5jbHVkZS9jeWd3
aW4vbGltaXRzLmggfCA4ICsrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCsp
LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvd2luc3VwL2N5Z3dpbi9pbmNsdWRlL2N5Z3dp
bi9saW1pdHMuaCBiL3dpbnN1cC9jeWd3aW4vaW5jbHVkZS9jeWd3aW4vbGltaXRzLmgKaW5kZXgg
MjA0MTU0ZGE5Li43MjhkZmQ0N2IgMTAwNjQ0Ci0tLSBhL3dpbnN1cC9jeWd3aW4vaW5jbHVkZS9j
eWd3aW4vbGltaXRzLmgKKysrIGIvd2luc3VwL2N5Z3dpbi9pbmNsdWRlL2N5Z3dpbi9saW1pdHMu
aApAQCAtNDMsNyArNDMsMTMgQEAgZGV0YWlscy4gKi8KICNkZWZpbmUgX19TRU1fVkFMVUVfTUFY
IDExNDc0ODM2NDgKICNkZWZpbmUgX19TSUdRVUVVRV9NQVggMTAyNAogI2RlZmluZSBfX1NUUkVB
TV9NQVggMjAKLSNkZWZpbmUgX19TWU1MT09QX01BWCAxMAorLyogX19TWU1MT09QX01BWAorICAg
aHR0cHM6Ly9sZWFybi5taWNyb3NvZnQuY29tL2VuLXVzL3dpbmRvd3Mvd2luMzIvZmlsZWlvL3Jl
cGFyc2UtcG9pbnRzCisgICAuLi4gVGhlcmUgaXMgYSBsaW1pdCBvZiA2MyByZXBhcnNlIHBvaW50
cyBvbiBhbnkgZ2l2ZW4gcGF0aC4KKyAgIE5PVEU6IFRoZSBsaW1pdCBjYW4gYmUgcmVkdWNlZCBk
ZXBlbmRpbmcgb24gdGhlIGxlbmd0aCBvZiB0aGUKKyAgIHJlcGFyc2UgcG9pbnQuIEZvciBleGFt
cGxlLCBpZiB5b3VyIHJlcGFyc2UgcG9pbnQgdGFyZ2V0cyBhIGZ1bGx5CisgICBxdWFsaWZpZWQg
cGF0aCwgdGhlIGxpbWl0IGJlY29tZXMgMzEuICovCisjZGVmaW5lIF9fU1lNTE9PUF9NQVggNjMK
ICNkZWZpbmUgX19USU1FUl9NQVggMzIKICNkZWZpbmUgX19UVFlfTkFNRV9NQVggMzIKICNkZWZp
bmUgX19GSUxFU0laRUJJVFMgNjQKLS0gCjIuMzAuMgoK
--00000000000035cb9e0637ff1e70
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple

--00000000000035cb9e0637ff1e70--