DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 53PIIUOv3472945
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6C3BE3858D20
MIME-Version: 1.0
References: <5e2eb205-c863-7575-628e-74a968b90a7c AT t-online DOT de>
 <CAKAoaQn9nJjG+Tt3q6+Ru9U2ndPg5WOBuTZ9+7PBjt_3g=-=Qg AT mail DOT gmail DOT com>
 <43168264-5f0a-45d6-ac27-dfbaae1b60cd AT maxrnd DOT com>
In-Reply-To: <43168264-5f0a-45d6-ac27-dfbaae1b60cd@maxrnd.com>
Date: Fri, 25 Apr 2025 20:16:47 +0200
Message-ID: <CAKAoaQnic25u=g1F8rw=r_64TH1jKZa-6guKs3fxBzbmz8BGEA@mail.gmail.com>
Subject: Re: cygutils 1.4.17-2: lssparse -H does not print hole at offset 0 if
 more data exists
To: Mark Geisert <mark AT maxrnd DOT com>
Cc: cygwin AT cygwin DOT com
From: Roland Mainz via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Roland Mainz <roland DOT mainz AT nrubsig DOT org>
Content-Type: text/plain; charset="utf-8"
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>
Content-Transfer-Encoding: 8bit

On Sun, Apr 6, 2025 at 9:53 AM Mark Geisert via Cygwin
<cygwin AT cygwin DOT com> wrote:
>
> Hi Roland,
>
> On 4/5/2025 7:56 AM, Roland Mainz via Cygwin wrote:
> > On Wed, Apr 2, 2025 at 4:01 PM Christian Franke via Cygwin
> > <cygwin AT cygwin DOT com> wrote:
> >>
> >> Testcase for a minor issue:
> >>
> >> $ > sparse_file
> >>
> >> $ chattr +S sparse_file
> >>
> >> $ dd if=/dev/zero bs=1M count=1 conv=sparse,notrunc of=sparse_file
> >> ...
> >> $ lssparse sparse_file # OK
> >>
> >> $ lssparse -H sparse_file # OK
> >> Hole range[0]: offset=0x0,      length=0x100000
> >>
> >> $ printf X >> sparse_file
> >>
> >> $ lssparse sparse_file # OK
> >> Data range[1]: offset=0x100000, length=0x1
> >>
> >> $ lssparse -H sparse_file # Missing 'Hole range[0]'
> >> Data range[1]: offset=0x100000, length=0x1
> >>
> >> The condition at lssparse.c:161 is never true:
> >>
> >>      141      for (i=1 ;;) {
> >>      ...
> >>      161          if (print_holes && (i == 0) && (data_start > 0)) {
> >>
> >> Possible patch attached. Important: Not tested with other corner cases.
> >
> > 1. *Thanks* ... :-)
> >
> > 2. New version is available from
> > http://svn.nrubsig.org/svn/people/gisburn/code/sparsefiles/lssparse.c
>
> This new version has been added to an updated cygutils 1.4.17-3 release
> as announced in
> https://cygwin.com/pipermail/cygwin-announce/2025-April/012256.html
> Thanks & Regards,

FYI I updated http://svn.nrubsig.org/svn/people/gisburn/code/sparsefiles/lssparse.c
to pass the Solaris/Illumos "cstyle" rules, e.g. the source now
conforms UNIX C formatting rules (no functional changes, this was just
to follow formatting rules of other UNIX versions).

----

Bye,
Roland
-- 
  __ .  . __
 (o.\ \/ /.o) roland DOT mainz AT nrubsig DOT org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 3992797
 (;O/ \/ \O;)

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple