DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 53NHLPUT2319601
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B31023858D26
Message-ID: <bc845803-dd04-4a39-b6f4-5da2b359c296@gmx.de>
Date: Wed, 23 Apr 2025 19:20:52 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: sqlite 3.49.1-1 package bug changing return types signedness
To: cygwin AT cygwin DOT com
References: <739d9722-f031-4981-9398-78b75d4ea2c6 AT gmx DOT de>
Content-Language: en-US
Autocrypt: addr=matthias DOT andree AT gmx DOT de; keydata=
 xsFNBFXwq5cBEADQxc9JeK4yqt1BX5tOMfzyIfEyBWXix0xqeAA/HQ2wd31NFcGFEbAevDsG
 oO7UcYQji1Gj/TggmclV37SHPDE++bU7O6Wur57FfTsVCmS6XjHj/n2qXgxrWtU7Fv9YOBz/
 wNge3sGAh2xbwh5dTt+Ew6TbuMbwXNonb4WUCo6yFMrDd2vg9RqcVSDpdLFO0JI9hNGLQDtH
 P2TbBfGj8V5qz9NFiGzRxmmFhMzqOSDCEs9uanr3TCLq7yZFTyAmXDCZuyFhxGwHDo6jB+9L
 bIprA/oH0uFol899hiIrZRm7kIAYsOSvp84x0XBFvSMoDY4ZA4Ucv3xk+aDqob0V5F4+W3Vg
 7bdlpbAuwov944Zawbm/sBGctNbfNeWjc+L7F43PbghzCfk6aLH0LwH3lNiu76F57lJqfTCn
 kBd0V0dUZ0/AJFskZu+aO/dCVkbfjotXDqsh55kBrSMsRX/rqt2d43q6o9AyWu5aMqLAG2ZN
 19qLu/a1vzbMEfRaimlFSo9LMY1jf5TcUc7mNlPDhm8c6o+Ivx/D0tSQ4V+3SqbroYgHo1A4
 Qyiau4sEP2YFtKbdRdpaN7WsdfdaZmrd9xa5lvp/gQZEdpLPzL0aBDEeUzaL/nee/EDQUbPu
 SYJCmDNyqxs/Y4j0ZGQmIPT1CY34AvdjIcLuT/BG1JZaIlKQ9QARAQABzShNYXR0aGlhcyBB
 bmRyZWUgPG1hdHRoaWFzLmFuZHJlZUBnbXguZGU+wsGUBBMBCgA+AhsDBQsJCAcDBRUKCQgL
 BRYCAwEAAh4BAheAFiEE3EplW9mTzUhx+oIQ5BKxVu/zhVoFAmZEAJQFCRX2730ACgkQ5BKx
 Vu/zhVoGfw/+NgdzCNX0Ma0brluHknO1fnntek35mQFOqNMOWDguIlW58z0Z4EHV1tJFPbqX
 jnPcUQiyRZ8RZ9eBlQs8qD2Mh6shkYUfwXyxl+ejJQLg5fcWNiZ3w/W5jTlk4R2FUD2w2oEk
 m6I20qxkeSdselTRWej9PvuIBrZSucvGz74xZtXjKr3Qv2G3iMYDneEnSzDZInlApQYPngEH
 MeiW7Jg35Y/91weC4kRsTeJF7XXJoUs1SYt/0LdkmGJouxh53DM9B02SCh3UiS8g3ZpzQVLo
 OKMuWsYkr6BKiBD50MdlEV2Fd7HYU8Ax+yc9YkQbdNXu1MXmg3+Xzgm4HJqZZCyVZqIQGdfT
 O95WYttVAbcihvkoC8nWYezAWWZexTF04PJ+iETirUwA+8TLjkja/kMC7aZV5ScIS6A7dL9a
 DCxRyILwecBwnKwV51dqNlqEvL5xJQ+thOOM5ahdW5h9aTty9KMOnrjf0o+qqiVYEMcnKhDO
 S3K0d78fsY/G5775Dcezx6n/0IRaWPNMF4TAJ5SO/V2odC5mMaYUraubbDupXrI+wMksNzrh
 AeuhgFdNmpVeWpjgSkf+jaMAeG4PbykD+ifZyCW046V6JTSDx0dmopac7kT82MApRr+YCIh+
 /O0zIFIiIWKNwReZplwbeV6QiycA6KhxBBEk8Qjdg6dYfdDOwU0EVfCrlwEQANcm7Ryn0O8l
 Xqblm756GabmqMTOsgikq65vzFZ8bsZOUfZg1bQRkDG6gzw8mVqpAxSnbZCTupEv1mR+rtxL
 Vujrs+LODABBydwYv//Aj4U2/yqoYGko3Cf0zN8GUS5autz6P2XgIUScApOq+PGy/hs5xKW2
 GuXnADbukpqdSweBaC5zCTiUB3VDpZNuuXHEBIMG746YxisJ7NwgXFAZ2cybupJQLC3ITHoT
 QIpeBfkdLZAq1XX+k8tKwiSIEZvaH/5q/zMWvbNSEFXHGao/F3t+JZq4ZZVRgM0jn27ZfZrS
 I0sGJFBP5jf+niwQgFe/4PdoidRYdDT9WAMVoSVz85mPaW7/LfRR3vu0h9pNIE/otC2ZxvlP
 dXO0ng6337RG/DlUiMCSKz4k7soBnqflMhb7u+QgL7Tiq44yaw7l/n/VejQ0WjMsEKufxk3n
 wZhHYSgHHrQ8yMMVTUyy8grtIOEPdt/gLYWdXYfZAKnQXhMf4aFVpuLsUbLnRVZyojjhAwj8
 gfinhaq38Vzx15UYLxgLx/o5wrocFq32JB9IDwuWFfdG2dRuXgMGXDgL4Rx9lKPPjmvhjdqH
 2XTtn6WshfBR3KmoYDWG+F4yhok1sWU1G/FgdjRRh55hrz/a2GgEPyZEmylK6tpB1friYmkG
 FkCv2O6UkqJyrJOBREpm6U1LABEBAAHCwXwEGAEKACYCGwwWIQTcSmVb2ZPNSHH6ghDkErFW
 7/OFWgUCZkQAtwUJFfbvoAAKCRDkErFW7/OFWsM+EACzYazhIR3zPhFU7pkPlOaSkgObA8Ht
 klXNjc2D2DHM9dV5FVkx6BW0dqzMYP13ATYePrlp9McFB+1MxAe6WObDbRr3CqFmie4vbxnn
 JS8K1SDy/yyovyA05cXIC9YZtdIlplD6PQFxtiN6j3gArDkfiJ89jwIMj4wou0y7P6Nu2CGd
 C1/ay4jjIqb5e8L37TOgsBrxYlZkYTzxZHT0E10AF2OtkXwN1rzVuJ0wV/8HnrrXA+ZdfjWb
 FZTo1PGez8ODlbMhm36AeL8W+PeBnTttGC7ibHC9gIlIiCTI7GrAv2IwE5d+2MXdx10df34a
 hZkyAxAzGhvm/KB1ADKNHUwRXCkon4l19LTlYpUOpqE4u6z0FisK6icZSHkuvMBitw9//mL1
 hmOKomzpMnhh31Jyihsv0a2MyzRQKmeMfXh5agVl0/QWgoJytgEcsAvvOrCedXssEzzdoZv+
 m9wEVYglslSWVR9TTP1X4ftL86S9gdZcIOLygbzJAttJI0MZ6+XbIhkPSonnfqCtSwwMC9mq
 TXFOelgFGe16RedBTORI3KB0JVSuoswtS1kS3vwFg2fwykd5YzDusMNe2UnUqSBa6ZrMvk4p
 d5tZa9f2Xh3V3DkOuUlBVzGFNj0kdU28JwIBWqi/2tHz0OORk/9+IteGPWYxG0vXoIhRiKbe
 hs+JzQ==
In-Reply-To: <739d9722-f031-4981-9398-78b75d4ea2c6@gmx.de>
UI-OutboundReport: notjunk:1;M01:P0:CaqYTBLlvSk=;DS5dk+3FIbtI/KcbhiISALnhiPv
 ps3uPJ+dMKrO91c2racZN8i2F5rfakpjhPNEMPtASnWAqbyAM2WI/UdspP0m+KgB7khS2GtTF
 fgB0D1NUv8Fq5UOBjLlFrtUmrZ1v09SwWLc/aLsYKF3vhwtZzZQ9MtkJkKnVstGiB0umMqBoM
 Uqw+1IFcrH+QVHll7UV81lMbMGV8fCfZZVEd3tGlXnzWuJm7N3893X23pUeuVQ7vCBpm9pQTB
 m6arNmz+Wt8AWZ28IqgZoPnOG6Wp/7oRpjgXbzsyjgg5eDf0QcqSJlF7d+jR45d2/QWjL1kym
 Y7aEd4MLD4gFJysFeS2VJm/HaZTYxqT2klDMnQkOt6ElR8p6VRjJeM7LclMA6fHc6+Ca2D6ER
 gHJ5zqXiT0QpvNBEXt8ZEVBUObSO5QealBH3ZcjKpwZifS4v1kclxF5tWlhj7vJJfD+ikeEQn
 6i+uXS+eTW6TtfR+Y6BpIFVYy5e7rRQqSrPLQmM+xJ/YDIDLDrxsHATA2DQS768rc5Ok/UmjQ
 yjDEYyS/u6kxbkK7vAE5bm5FnKLNDRduZ5w5uvkDBbC57h4su3/qbYotFFtalbibCFbrzqD9U
 LeeDnZATIfY9UPOO3EYrELcE0Y/SlKqoWRXyXUsaaBKXSUMchGm64ryP5QtCaBKNi+9AtoBDr
 tAvQyDIjcxmDD5MIdVxNHhEnKvzcFMyLkWRXlDDkHCZBJSJWyZoaYuFsYgaH4GSfDfsCx0ILm
 2bmoLJpugqCp6Vz7wx0+h5uSo//pZHk0gCbkqHkkRKFnjs5Cn4XVC+pHqOJiU9sQpsDADEDZS
 6T5nIl2VqYUiMfZ42nyybBoLkevDCBlv7zIeBv4tsM0HGoGaPIehpvkX5AWYaDw1Vv7g4TIrr
 iLudnIAZcl2KfdRQEUS1p/AFkkq/5QWda6WuMLJ1HdbWSzotl38hBLAjb1OwpXcUMXOYAZlcC
 hUOBTtGtAD7bID3TR2VUkqBymT/SJ0Zh+uJJMuMT8gnq/w8jegbj+bkmvP49Q9/ZypoC+mLJg
 aNJVbpUvHhkPUnkurTN5SjXT2bYBMrPt3OkOnnG8ILA/VPNA6y76JnC+HEaSs8GRCAHnVdBPw
 3Am6e640UTxxhxAeAVw1yspEICoIosKZHbBU4N+ENC8jfxpC0/Y0nhQhzPfZz6j59coH33652
 Z/GOdyEoh52La4n0rbFgWhEmXvf0cc52Auj+sGJzQGu4WCtXqKYiFdcoCdMu4/pcL4uvpSNvu
 ly526/jbDJO6zUBKYWULnHtvsuXCdCCPHCtLftT/ZqJ1nsaAcmekEV5lEQGAEgyNh3fip6xpu
 Y2J4cYm135/t8uU7EWYLjbfIZ962PNT2+iE3a2OffV/SoMCbbwTEOD5k3QrgpmoJ6ZYNkqSLL
 1aXpTrRDyVdbLapcS5vVfZgcuZnBuzk+Y5Im/wbEyYDkL02wcgX/HzjH/h/1PVWij1tv9hU9V
 1TUw4Ui7y51j2BDG30ljkGrzzRciKM6wyht170HB4pShG2pwXC1dltcHgmh46rSQsI8LlESFA
 cLMfekoMI33QhIhazJCE3O5Kj/+oMv3+ajYKqqmi3ZOkzIOIU4xui40zo6qskGfbkSpQrvcSb
 UP78KdzfMTr4nPVQryXvDqKAE8ZKOxLR2mtPjJp96QkFao7RiU/pbDSYVvbK+n1IMy76rl0Zo
 OayH4DO/8h+jIUQn0mseEN8rFQsFi5hlZ2nSBoCgUx2zUuxjnmQK4CalyqHUGKew9bzstexq/
 f+L/Mz5qEICnT4txJxWKNN3PYYEp1kmYkWdv8FZlhlUkYs+gn8FrW+zZfRmjgoZ/Rr0Dj2agg
 T1KThXcC4G651pLE0fAqmIDektFXJx8hi9cl9pHPpboiU7HpFMWTZ/4t3LNlXojDEXGGzNlEw
 CRd4oXwndNPGoZawnazucImQXID+hJggpgRTbSoZlTYUrLd819oH1P7YstdbNN34jngffOgic
 Z4nteAkB8+XJAK/uHl0brmrIyEsRwuk/zs+bp45HnmsuE13MbWdAohgA+vRV/aKWcyaBLsbBD
 yZ2ntQUxrDKfUzoN+4aDdt/RssMr8//Q1mBhwMBdJ45zKII4kvIgn6vRjj9NDJ7+Cr1vKcjMI
 DQjFesu1l1Fpa/fd7L9SF5zTKMRa86kyiPsIRXLsmq1EGcW532wZPTfNvn5BJJl4ZgYuO312z
 uQ5rPVyhxhJE/tV0OKQ9e9YOM46J7leZT9cRrjsJ1VI2w1opsq2zEjjjHONVJtMWM0HlOVQwj
 wFKYlxgaE8hw33Lr8G9ckt0W7tEKbVpfG35rS0LdcSVfabcDc/D3GN9jQvROm71/ny7/ETNGU
 Qvqfzfsw9xqOkxQ76Lm6JqnDUpfgtYn4WGHm22JuWufq58Mrg0zJTWMCIqWUqHi31Xko9Ai5f
 vR/UyReDpqsM/Ptz38HzLrQx/QL2p5g2bC7m7dcEttQybnsBXca9mL+L7DpIHDT4o53bCmuh/
 IcAOYNaKB/2YtnaTS+hX+dd/MlYxMApOEDu6jV0+su1Uclhu8jJG9oFaSSo45J9jrHdrELnIU
 5TgzV7kf/i3KtJgAOUS8f+QSbQ3p2BjpKo4xudSmXMRTRn00X8Py8uULXyDQT0PkP3gmGLk53
 htMZCqYq4BF/9Zy0BXN27BCduEmnfABm1mdptnRBDR+G+VIlVTfuMsP+gNtxS8paJyKZJ/wFM
 9qMxW/mhcwNuZMthVOoWtsqSMppYRivO4jglsRUS572AXNYjbEhsKJTQVhFI3GaHzxP+xRPdx
 vLY4JDmadCX3JLqeBzb/YPYQ47rae026ZsZsdBxp5AKMzOYM/9CWtL1Znvuqm2TclEsyQRxMC
 Hgb3JR67rkzG/7IXtGjCw0l/y5TftAAo9Yp1OP20Jkb6f8kvwiDtqPeoHgdGz/NJaA6xQ7dWJ
 ybDWePjCRO6dtubcpt+9suMac7o6yqNLhnyi3rozD7AhYIRsVdKt/zyVRn9KW44LarmPLKbO6
 6cZt8jIhKhudl3B1Fll5g9afy+0nJiDYtPGvZJEwLFqqv0koFBxpfv2Kw+xljwV/xSUFG37m5
 6LbyUxOe/53HK6nb0knJRzA2VLtjBWIVPGB5CWZoHQ8dk5rSG+/QJB53RjjjPSurQ==
Precedence: list
From: Matthias Andree via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Matthias Andree <matthias DOT andree AT gmx DOT de>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

Greetings,

I haven't heard back from the issue I've documented below, or from Jan 
Nijtmans, and it still needs attention.

The changes I've documented below actually introduce integer overflow 
and maybe memory violating conditions in applications that work fine on 
other operating systems, as opposed to when they are compiled against 
sqlite3 on Cygwin.

I ask that we get a new Cygwin package of sqlite3 that fixes the issue I 
mentioned below.

(Yes, this isn't the most favorable tone for FrOSS communities, but then 
again it addresses something that was deliberate, ill-advised, and broke 
the package, and I preferably would like to see the party that broke it 
to also fix it because they usually know best.)

Am 25.03.25 um 00:15 schrieb Matthias Andree via Cygwin:
> Hi @Jan Nijtmans,
>
> thank you very much for updating the Cygwin package to 3.49.1.
>
> I would like to ask you to stop changing API return types, such as the
> one here, where your patch converts the sqlite3_column_bytes return from
> int to unsigned int. This is from sqlite3-3.49.1-1's patch
>
> -SQLITE_API int sqlite3_column_bytes(sqlite3_stmt*, int iCol);
> -SQLITE_API int sqlite3_column_bytes16(sqlite3_stmt*, int iCol);
> +SQLITE_API unsigned int sqlite3_column_bytes(sqlite3_stmt*, int iCol);
> +SQLITE_API unsigned int sqlite3_column_bytes16(sqlite3_stmt*, int iCol);
>
> While I appreciate that it would have been adequate if the original
> return type had been unsigned int or size_t for that matter, you cannot
> change this in a downstream package. This would take sqlite 4.0 to 
> change.
>
> This does break applications! Who would special-case applications
> because some downstream packager changed API?
>
> See
> https://softwareengineering.stackexchange.com/questions/175253/why-does-an-unsigned-int-compared-with-a-signed-character-turn-out-with-an-unexp 
>
> and (C++ based but has the same underlying problem because C++ uses the
> same type promotion rules for int-like types):
>
> Useful context also here:
> https://flak.tedunangst.com/post/subtraction-is-not-comparison
>
> Please revise the sqlite3 package and make sure its API functions return
> the publicly documented return types even if you do not like them or
> feel they're wrong because good applications will have adapted.
>
> Thanks in advance.
>
> Best regards,
> Matthias
>
>


-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple