DMARC-Filter: OpenDMARC Filter v1.4.2 delorie.com 51EEkFin1584866
Authentication-Results: delorie.com; dmarc=pass (p=none dis=none) header.from=cygwin.com
Authentication-Results: delorie.com; spf=pass smtp.mailfrom=cygwin.com
DKIM-Filter: OpenDKIM Filter v2.11.0 delorie.com 51EEkFin1584866
Authentication-Results: delorie.com;
	dkim=pass (1024-bit key, unprotected) header.d=cygwin.com header.i=@cygwin.com header.a=rsa-sha256 header.s=default header.b=U0ffMhmh
X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 860E43858420
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1739544374;
	bh=KfiCVu4whdT1tqyAQ3dm3hwxDxiXXjbBBxXl79xWO9w=;
	h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	 From;
	b=U0ffMhmh5Eh2u14ZCQc97xU39Lt2nyLLQZBTnJZ5eWiDKyjgz/PqaDjHbiDVa2EYZ
	 aKvl0Pl+umWHTCKjb9xXqih0msyexBFPIjYXT74/pCbvoyJ+knR+3XtI/40XMlJLGs
	 4C6nqnrZyVDCI2RDoNy7iCAqj3W9nBmylef2pHHI=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5645D3858C53
Date: Fri, 14 Feb 2025 15:45:16 +0100
To: cygwin AT cygwin DOT com
Subject: Re: SEEK_DATA should fail at EOF (was: coreutils-9.6-1 (TEST): cp:
 infinite SEEK_SET/DATA/HOLE loop if file is compressed)
Message-ID: <Z69W_GcJIEc0y__g@calimero.vinschen.de>
Mail-Followup-To: cygwin AT cygwin DOT com
References: <614771e9-592c-6154-d56d-13842b6fc6ac AT t-online DOT de>
 <5ccdf4be-4e4b-1846-9fd6-cba29c9dbb11 AT t-online DOT de>
 <Z6878Laugk31H2oO AT calimero DOT vinschen DOT de>
 <Z69BwMKCqG4LPk28 AT calimero DOT vinschen DOT de>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <Z69BwMKCqG4LPk28@calimero.vinschen.de>
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.30
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Corinna Vinschen via Cygwin <cygwin AT cygwin DOT com>
Reply-To: cygwin AT cygwin DOT com
Cc: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces~archive-cygwin=delorie DOT com AT cygwin DOT com>

On Feb 14 14:14, Corinna Vinschen via Cygwin wrote:
> On Feb 14 13:49, Corinna Vinschen via Cygwin wrote:
> > On Feb 14 12:24, Christian Franke via Cygwin wrote:
> > > Hmm... does "beyond" mean '>=' or '>' ?
> > 
> > ...do you think this fixes it?
> > 
> > diff --git a/winsup/cygwin/fhandler/base.cc b/winsup/cygwin/fhandler/base.cc
> > index 8f3dbd4ed51a..79dfaaa5987a 100644
> > --- a/winsup/cygwin/fhandler/base.cc
> > +++ b/winsup/cygwin/fhandler/base.cc
> > @@ -1144,7 +1144,7 @@ fhandler_base::lseek (off_t offset, int whence)
> >  	    return -1;
> >  	  }
> >  	/* Per Linux man page, ENXIO if offset is beyond EOF */
> > -	if (offset > fsi.EndOfFile.QuadPart)
> > +	if (offset >= fsi.EndOfFile.QuadPart)
> >  	  {
> >  	    set_errno (ENXIO);
> >  	    return -1;
> 
> Yeah, it does.  I'll push the patch.

Patch is in the latest cygwin-3.6.0-0.373.gfac7441835b0
test release.

We're probably releasing 3.6 in the next few weeks.


Thanks,
Corinna

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple