DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E360C3858C32
MIME-Version: 1.0
Date: Fri, 22 Mar 2024 14:49:07 +0100
Message-ID: <CAKAoaQk1ofn+6e4LGsAbFLgPm_C9S6h_Pik8cTC=uVQ247d1xg@mail.gmail.com>
Subject: Updating cygwin "libnfs" package ?
To: cygwin AT cygwin DOT com
Cc: Yaakov Selkowitz <yselkowi AT redhat DOT com>
From: Roland Mainz via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Roland Mainz <roland DOT mainz AT nrubsig DOT org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>

Hi!

----

Is it possible to update the Cygwin "libnfs" package, please ?

The current Cygwin "libnfs" version is rather old (per
https://cygwin.com/cgit/cygwin-packages/libnfs/log/ last updated in
2016-11-16) and has a couple of NFSv4-related bugs, for example:
-------- snip --------
$ nfs-ls.exe "nfs://derfwnb4966_ipv6linklocal/net_tmpfs2?version=4"
Failed to mount nfs share : mount/mnt call failed with "Server
responded: Program version mismatch"
-------- snip --------

Building the current version from https://github.com/sahlberg/libnfs
with Cygwin 3.6.0-0.99.g290843bbdab6.x86_64 is easy:
$ git clone https://github.com/sahlberg/libnfs.gi
# apply this patch:
---- snip ----
diff --git a/lib/nfs_v4.c b/lib/nfs_v4.c
index 178cb94..f811fcf 100644
--- a/lib/nfs_v4.c
+++ b/lib/nfs_v4.c
@@ -433,7 +433,7 @@ nfs_get_ugid(struct nfs_context *nfs, const char
*buf, int slen, int is_user)
        const char *name = buf;

        while (slen) {
-                if (isdigit(*buf)) {
+                if (isdigit((int)*buf)) {
                        ugid *= 10;
                        ugid += *buf - '0';
                } else {
---- snip ----
$  cd libnfs/
$  autoupdate
$  ln -s /usr/share/libtool/build-aux/ltmain.sh .
$  automake --add-missing
$  autoreconf
$  ./configure --without-libkrb5 --enable-utils
$  make all
-------- snip --------

After that "nfs-ls" works:
---- snip ----
$ ./utils/nfs-ls.exe
"nfs://derfwnb4966_ipv6linklocal/net_tmpfs2?version=4"
drwxrwxrwx  2 65534 65534           40 test2
drwxrwxrwx  2 65534 65534           40 test1
---- snip ----

----

Bye,
Roland
--
  __ .  . __
 (o.\ \/ /.o) roland DOT mainz AT nrubsig DOT org
  \__\/\/__/  MPEG specialist, C&&JAVA&&Sun&&Unix programmer
  /O /==\ O\  TEL +49 641 3992797
 (;O/ \/ \O;)

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple