X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5AD0F3856962
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1690494042;
	bh=HVnjL48q562/6u7AAyI8384ZAhjmZ7Eh3t5TZzc8EgU=;
	h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:
	 From;
	b=DBd4WNHmLWUKeksKHIUnt2p1sY7gYo2+aVooz5YGZHAGxxEDt+EHiNQYu0TP4Or82
	 2bERpVTB3ZNdRO6u5ML3C2GmtjOnRHnXt3J+JthSRkRqw8fnSl5Pb6zQGsh1MjxZ1V
	 w9jIjyRSl6PIQdRvu/l7BoNwGa6GJMRK195rz0RI=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B9B23858D37
ARC-Seal: i=1; a=rsa-sha256; t=1690494023; cv=none;
 d=strato.com; s=strato-dkim-0002;
 b=bBkJWB8n94CG27mgu5YdSp/rQ3FP3SDAXN3HRy1B9gniYNKtARcaInA30ZmMsU8p5C
 YLE9EILm4b4qHmwA6LeGG9Ko4eEZXggCu8B3HJDVdJcL7jGQ9egsRXh4C/TojNx1hAOg
 jSZD8dmaYIzWwRcoN2Fcc4Eo4kL0QkpNNX/lU+ENXQIITP8741bEqsedRLyvFFPuncq/
 rbEWethwSKaCpmRrCj1Urlr8n67DxWBdUhQ/jbMtyJgcfgUcXFVT4wrSIEfHvy8f0otk
 EMrsHMLe9bUuulXno4E1q5kNy0T6LsuedPX+fyBsVoiP/wGMMhJl8zysD0CZtYHnuxVi
 QWxg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1690494023;
 s=strato-dkim-0002; d=strato.com;
 h=References:In-Reply-To:Message-ID:Date:Subject:To:From:Cc:Date:From:
 Subject:Sender;
 bh=njZFGZ9kiqAJY4fnPr561GMv7IfBOCbcVQqHDshlnCw=;
 b=CoEpwZE9B7RRtVYQFDq+6rk8w2mUvyL8/dGr9AIkTXExMHJ4kwtunhqC+lT9IgtTc+
 PsGjOes78q8+qmZyRk6zc74yLaqxfGLQJduO7tBIhTEo9RIwVDFsaQx4IMgIl+eJbi/I
 ggaNTOLBSxfZhlzmuO9GjM5NorNeEyzZmF7koDpGnkKCPx3gNquzVnXhy7q6O3Vv6u5v
 VKKpfzglPJkVcQrsOWeUc+W9DoExPv/aXbCLdI8MVsKsW89YvWeY7SMW8wA2qUgaofor
 yi/vLT+rUc6CrV3/evYGsfwL8SB3tVhEWzFQaOrhMAEWkH5HSUfHq9VqZsm+/8F9YvSw
 uyqA==
ARC-Authentication-Results: i=1; strato.com;
    arc=none;
    dkim=none
X-RZG-CLASS-ID: mo00
X-RZG-AUTH: ":Ln4Re0+Ic/6oZXR1YgKryK8brlshOcZlIWs+iCP5vnk6shH0WWb0LN8XZoH94zq68+3cfpOU3vHMHGOPJ/ArHF88rp8ePd9i2g=="
To: Corinna Vinschen <cygwin AT cygwin DOT com>, Bruno Haible <bruno AT clisp DOT org>
Subject: Re: fnmatch improvements
Date: Thu, 27 Jul 2023 23:40:23 +0200
Message-ID: <12689051.0j3nEXixpK@nimes>
In-Reply-To: <ZMLADRFGUuvEnCT+@calimero.vinschen.de>
References: <3884636 DOT 3uDm00564X AT nimes> <ZMK2UVB71pEeoFDK AT calimero DOT vinschen DOT de>
 <ZMLADRFGUuvEnCT+@calimero.vinschen.de>
MIME-Version: 1.0
X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE,
 RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NONE, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Bruno Haible via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Bruno Haible <bruno AT clisp DOT org>
Content-Type: text/plain; charset="utf-8"
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by delorie.com id 36RLehEw005414

Corinna Vinschen wrote:
> > >   4. cd testdir-fnmatch-posix
> > >      ./configure 2>&1 | tee log1
> > >      make
> > >      make check
> 
> I fixed the above problem and the POSIX check now works fine:

Glad that the test suite was helpful (and that you fixed it before 3.5.0 —
so, no additional configure tests needed on the gnulib side).

> > >      grep fnmatch log1
> 
>     checking for fnmatch.h... yes
>     checking for fnmatch... yes
>     checking for working POSIX fnmatch... yes
>
> I also extraced the fnmatch configure testcase and ran it manually.
> It returns 0 now.  But:
> 
> > >      grep REPLACE_FNMATCH config.status
> 
>     S["REPLACE_FNMATCH"]="1"
>
> Looks like the reason is that we don't have a uchar.h file?  Seems 
> like this is of interest for AIX, but why should this be of
> interest for fnmatch on other systems?

Ah, that's because I made the assumption that if wchar_t is only 16-bits
wide, fnmatch() can't be correct. Which is true for AIX (and on this
platform, I prefer not to test the available locales). But not true
with your implementation any more.

What are the test suite results if you do

  - Replace S["REPLACE_FNMATCH"]="1" with S["REPLACE_FNMATCH"]="0"
    in config.status,
  - make clean
  - ./config.status
  - make
  - make check

Then the tests will be run against Cygwin's fnmatch() function.
If all tests pass, I will add the following patch to gnulib.

diff --git a/m4/fnmatch.m4 b/m4/fnmatch.m4
index 2e1442eff7..e99737a476 100644
--- a/m4/fnmatch.m4
+++ b/m4/fnmatch.m4
@@ -1,4 +1,4 @@
-# Check for fnmatch - serial 18  -*- coding: utf-8 -*-
+# Check for fnmatch - serial 19  -*- coding: utf-8 -*-
 
 # Copyright (C) 2000-2007, 2009-2023 Free Software Foundation, Inc.
 # This file is free software; the Free Software Foundation
@@ -14,7 +14,7 @@ AC_DEFUN([gl_FUNC_FNMATCH_POSIX]
   m4_divert_text([DEFAULTS], [gl_fnmatch_required=POSIX])
 
   AC_REQUIRE([gl_FNMATCH_H])
-  AC_REQUIRE([AC_CANONICAL_HOST]) dnl for cross-compiles
+  AC_REQUIRE([AC_CANONICAL_HOST])
   gl_fnmatch_required_lowercase=`
     echo $gl_fnmatch_required | LC_ALL=C tr '[[A-Z]]' '[[a-z]]'
   `
@@ -164,7 +164,17 @@ AC_DEFUN([gl_FUNC_FNMATCH_POSIX]
     dnl This is due to wchar_t being only 16 bits wide.
     AC_REQUIRE([gl_UCHAR_H])
     if test $SMALL_WCHAR_T = 1; then
-      REPLACE_FNMATCH=1
+      case "$host_os" in
+        cygwin*)
+          dnl On Cygwin < 3.5.0, the above $gl_fnmatch_result came out as 'no',
+          dnl On Cygwin >= 3.5.0, fnmatch supports all Unicode characters,
+          dnl despite wchar_t being only 16 bits wide (because internally it
+          dnl works on wint_t values).
+          ;;
+        *)
+          REPLACE_FNMATCH=1
+          ;;
+      esac
     fi
   fi
   if test $HAVE_FNMATCH = 0 || test $REPLACE_FNMATCH = 1; then




-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple