DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 916B23858419
Message-ID: <7c5526d0-433d-3709-f420-56446f7b4dea@cornell.edu>
Date: Tue, 9 Aug 2022 16:11:38 -0400
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Subject: Re: Deleting a directory with the same name as a shortcut deletes
 everything in CWD
Content-Language: en-US
To: Oskar Skog <oskar AT oskog97 DOT com>, cygwin AT cygwin DOT com
References: <4b9acea9-b098-2c06-4530-10a4e9ca42b6 AT oskog97 DOT com>
 <003884bf-bb7a-984a-668a-21221f142638 AT t-online DOT de>
 <bf4b113b-f22e-5a55-9da7-27ff5b16302b AT cornell DOT edu>
 <b1090ef6-9f8e-bcf9-6d99-799d16340571 AT cornell DOT edu>
 <4f214d07-fc9b-ab8e-ee39-a686af5ca053 AT oskog97 DOT com>
From: Ken Brown <kbrown AT cornell DOT edu>
In-Reply-To: <4f214d07-fc9b-ab8e-ee39-a686af5ca053@oskog97.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzRLVUozRlBFandOV1ljMmt5aTVEYnFleEcwVnp6TFJMR2VTYnFwK1NocTRL?=
 =?utf-8?B?TWFhRUYyVHZjdU5vbUpuanZXa0ZLekZuYUNMbTJNL1EzbmdnbFgybndWcE5Z?=
 =?utf-8?B?dUFtSk5pNXpkVmcza0JjMkxSaUN6NGZzVzB2RGkwMVROY3M2eUlXaml6RUpJ?=
 =?utf-8?B?ekZqbStwSSt2bnlES2RibDA3UDdvRkJtSHNQRDRJNjJZTGFFYWUwTEl0OXFC?=
 =?utf-8?B?MTkwZVpNT1RscGpZbE96YkI0dlM5R2hJUW92Tm95RU5DeEhUVXpjdStRb3VJ?=
 =?utf-8?B?ODVyaTBTRWo3cWx6SG9jUzNBd3hiUTdlNEw3Q1VTR01PYno1WjBlc3hvejNT?=
 =?utf-8?B?dnhvOE5qTVdiTDdZUGRTZHltOEtJOFVZamlRN3pZY014dUtueC91L1JlTytC?=
 =?utf-8?B?cUVkd016QUdUWlFZbTcyVWVnUXFOWnE4eVFDNXY5a3Fzc21IRE5hSkx6KzVV?=
 =?utf-8?B?eWE5c3o4dld0UG9WWVdkRFJKU3REZEhnMVlVejYySmNrY24wd1U5K0dnc0RJ?=
 =?utf-8?B?RTBIWXo4d1Qrc2F2T1pCVFRtSUtQRWJod05HR3IyTEpPekdLSElSL0RodGxP?=
 =?utf-8?B?TW90QnE4R1FBL2FZekd3Y1BnbmF2UHRwWXRjQnNYYXYvRy9UbW5MMXNwOWpK?=
 =?utf-8?B?UG0xcGlWeW9uZ1FIeXdGdHd2Y2hVYndkMTVjblZaRVVYd0YrZjhYY1dkVUVw?=
 =?utf-8?B?djJmTzdhUGFoWGw4eituakdEVkQ4N3hoOU9mdkFiaG10Vm0vejB4OGdQYkVn?=
 =?utf-8?B?NEVQTEQwSWYyZll1RWJMNU9SMHV6L1huTkRhRVREdEpKUjNCTHZhZURSNjlZ?=
 =?utf-8?B?ZThzaEV0YUxqTlVrUWhKRW4rZEtlNmdRYkRFKzc4WWt5THBDTlNUMlR3eTh5?=
 =?utf-8?B?M1cyd1U2bUxuWUNFclpaZTBUdHlNTVVjMkxpZHNFTER2UHJrRUJybG5uQ1Y3?=
 =?utf-8?B?QmlFR254MlVZRFdsbmMrT1RzaDNuOEhCRzVrWmlDTFptTUNhVVovTysvbUpa?=
 =?utf-8?B?clZwSDM3V1B5cGxNM2NtemZMUkRaSXRkMHFSNytSL1NrSkQ2d2UyUW02VFBy?=
 =?utf-8?B?MFBsbGFHbEMyU2pjQXRBaTdWMFB0SHdVS0lnWUJzcG1UREpWTDF6dm1PRUcy?=
 =?utf-8?B?aUN2NWlZMlJ6REdSWDNIV1ZsdlhDL3BXQlhXd1BhNG9xcktjZHk3d0hGdUpy?=
 =?utf-8?B?cGVVdCs0ZWs5NGNEdGVWZklJam8vWFlIWUJ6TW5aeDdWNmRoUkVmVkJnL1pl?=
 =?utf-8?B?c1VtbFdCUHRDVDBDd2NENTZlNXhCNGpZYkhVaGFlWkx3RmJzSnJ0L3R2VG00?=
 =?utf-8?B?Zm42OTdWR280bU5temN3TXRyQ1czcVdyb1hHcEM2NUV0WWVIVFBOTVdKTndo?=
 =?utf-8?B?Rmp4OVphNUhEN0cvMFNLaldUUW9HZ2x6cVpQejRrQkpYUkhEZUFrWlB1cGNP?=
 =?utf-8?B?LzNUUDF1ejM3TStQcDRoZ0xsT3VGeVM4Z0s5V0R1OHNkb3hFU3pwTXhiWVQx?=
 =?utf-8?B?SjBCdkIrd1k2Z2s0WmFIZEJUOFI5NjRSYkN2ZGdhYXFqWGtrRVpBL3d6Ymsw?=
 =?utf-8?B?RlQzSTJSTlcrbzJJd09IbDNrQ0d0T1hrYldEU0Z0Y1VrcGs0NC94UzlOSFA0?=
 =?utf-8?B?ZXl2SzRtdk1pbVFQclo0NEcweTdkTTFqcmVaMXJCUGdSVDY2T0RiSUhSQ3JX?=
 =?utf-8?B?dU8vb1pIZHFwek0yZWtQRTZiYzAvR1ArRzhnYmFvWjAxd3BzNWIrdlZOc3dK?=
 =?utf-8?B?a29ockJyemFYVEVtak1veEpReVArKzJXOHoyZW9Pbk1qM2wwL2hJS2RWOXVi?=
 =?utf-8?B?aGoyb2tTaWVLdDdlbzFoR0I3WjJrNlFHVlF1OWYyUloyOEkvbW8yZXpvTS9D?=
 =?utf-8?B?bnFnUVhyRjhVMWJtZGUvSnlOdkpUSUI3bVBMbWM4cm5XWVRuVWJRdFd5a0dj?=
 =?utf-8?B?RHFuQVp3NTFTWWNPOGJQNWJwQW10MzhhTnk0M3dvQ1BsaVlhaGVCMzB4aUsr?=
 =?utf-8?B?ZGJUTDFqSUJPN0lqQ0w5b05XSmlDZ2NHNFBqV1BjZkFWdnhuLzZWTTBhNUl1?=
 =?utf-8?B?NG9Mc1cvVXdnanRvZDBkb205UklLU09yUjErQk5jYXRvUGxuYXZDUnJtSjA0?=
 =?utf-8?B?YmF4ZUdhT2REdFd1M0ZIbW14d1FtNGZnaHE0N2kxaGE3ckJZV1VkUHJYVUs3?=
 =?utf-8?Q?yp21X5z47HHyv9Nb8hYbUdfQoRnZinblttbVmvH3nG6+?=
X-OriginatorOrg: cornell.edu
X-MS-Exchange-CrossTenant-Network-Message-Id: 63b34b04-f97d-4a96-bdfd-08da7a435ed4
X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 20:11:40.1244 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fu5Ttyy8pUtxmoZYesOApGdXtM4cryOSOXNPHAYgJUOzkSMn7oo+1wlozzx+sJslS+kRsCqzVv7hmioMK4QXtg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5583
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, NICE_REPLY_A,
 RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Unsubscribe: <https://cygwin.com/mailman/options/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=unsubscribe>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <https://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Errors-To: cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com
Sender: "Cygwin" <cygwin-bounces+archive-cygwin=delorie DOT com AT cygwin DOT com>
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by delorie.com id 279KCNcq012613

On 8/9/2022 4:01 PM, Oskar Skog wrote:
> On 2022-08-09 22:52, Ken Brown wrote:
>> I think the best fix is to set res = 0 at the beginning of the loop and to 
>> remove a "res = -1" that occurs later.  I've sent a patch to cygwin-patches.
>>
>> Ken
>>
> 
>  From https://cygwin.com/pipermail/cygwin-patches/2022q3/011994.html
>  > Currently it is possible for symlink_info::check to return -1 in case
>  > we're searching for foo and find foo.lnk that is not a shortcut.
> 
> Does it matter that it is *not* a shortcut for this patch to work?
> 
> I first experienced this issue using an actual shortcut, but simplified
> the reproduction code.
> 
> mkshortcut -n Foo.lnk ...   ->  touch Foo.lnk

It still works.  I'll fix the commit message.  [The code in question is actually 
checking whether foo.lnk is a shortcut that Cygwin treats as a symlink.]

Ken

-- 
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple