X-Recipient: archive-cygwin AT delorie DOT com DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1BAD43835434 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com; s=default; t=1612015127; bh=MP15W+ktJGnWnqFFaY7fSggTVVB3jV135wwRcWpe59c=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=NtAC3eOapD+6dzbNiZXJvbzJg1zG7DS6yetiOoPQqS5MrajdSDx+ETWlPHsitWIQN WAcm9YJvkoHH80xWN4UnDCWhPx5GSpM1M0YEY6ESB46oK+2ND2GAL2xnYppGI5/Rzm r4ARWgjeSVw0CDMVkPSkWmtxLpxaX+Cs1Cz6EU4E= X-Original-To: cygwin AT cygwin DOT com Delivered-To: cygwin AT cygwin DOT com DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 89F283857800 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PEVZcu2GTMz1I5VuMV1/PKVYHRJ625zDKyRG1ERCESA=; b=VDP6Ipdm+a+JpnFryQiDeIsLnztZFmwQxXjQjEM28ao6KIrD2usoD0JTK6LTPz06a5 uWSH13gXX6EYWZVLsv+uFDYKqHBEBmjwPQN2vR1t6y7ar7PokW4VWo9dRE2CBSLWe1MN N2Q9Uc0paxzDWo45bLCyD20WlHZs83JEECPbF00OkRm/attZUuNqbqwroVbDA7ZlPN7B TscR1UAWuhBPpzk9b1iGiSHXPBlO3sL8JZz4CUPEHQCVzXdnhkH2BWpSnqNhh7i8mImk kxcHsc90yPQPJYv0qLX2OvoTOTXDnCty5sbJQrxodppKeRu9KEfFnT46LSuCU2M5apG6 z5nQ== X-Gm-Message-State: AOAM531L5PelKd7n87GWvyc0p+pjwoyVvJk8dGSWOCVBVKFNVNRsqqIK EEFWy1J27ZjwThqQD7juYTQ4yzJP1gV6Xg== X-Google-Smtp-Source: ABdhPJz0ONR9l8ty2TK5XN7nwc9dvPINWdX3jerA6yNsB2pIzz5ahbw+Z320UUgO5mDpqHrFiPzhuQ== X-Received: by 2002:a17:906:494c:: with SMTP id f12mr9251510ejt.56.1612015122993; Sat, 30 Jan 2021 05:58:42 -0800 (PST) Subject: Re: python-cython C++ support patch To: cygwin AT cygwin DOT com References: <20210129 DOT 193143 DOT 371461372727925270 DOT trueroad AT trueroad DOT jp> <7edac602-ab79-7421-f5f8-929c7fa68428 AT gmail DOT com> <20210130 DOT 222850 DOT 1144915727792964409 DOT trueroad AT trueroad DOT jp> Message-ID: Date: Sat, 30 Jan 2021 14:58:42 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210130.222850.1144915727792964409.trueroad@trueroad.jp> Content-Language: it X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: cygwin AT cygwin DOT com X-Mailman-Version: 2.1.29 Precedence: list List-Id: General Cygwin discussions and problem reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Marco Atzeri via Cygwin Reply-To: Marco Atzeri Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: cygwin-bounces AT cygwin DOT com Sender: "Cygwin" On 30.01.2021 14:28, Masamichi Hosoda wrote: >> have you considered that you just need to define >> CYTHON_NO_PYINIT_EXPORT ? >> >> the portion of the code below your change has already the >> ifdef __cplusplus semantic >> >> Have you proposed it upstream ? It does not seem >> a change restricted to Cygwin >> >> Any way I see no "wrongness" to add it on the Cython rebuild > > Hi Marco, > > The relevant upstream source looks like this. > https://github.com/cython/cython/blob/0.29.21/Cython/Utility/ModuleSetupCode.c#L712 > > ``` > #define __Pyx_PyMODINIT_FUNC PyMODINIT_FUNC PyMODINIT_FUNC unfortunately dos not work and my changes try to overcome it, see similar on https://sourceware.org/pipermail/cygwin/2021-January/247211.html but your portion is for additional C++ case than I am adding in asimilar way Regards Marco -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation: https://cygwin.com/docs.html Unsubscribe info: https://cygwin.com/ml/#unsubscribe-simple