X-Recipient: archive-cygwin AT delorie DOT com
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C575F38708FC
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cygwin.com;
	s=default; t=1590926465;
	bh=V+I3Sb8PFnAVT+CRjc7AHTNPDic0AKIbTwUwZvuE/lo=;
	h=References:In-Reply-To:Date:Subject:To:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	 From;
	b=HPE4nTabMFww4xR0T/UvMEJ7PKjdRK/lLqaiuXrJlQOcfUkW4oLakMQfCITJSQRwx
	 PC+TWRyko27roDu2d8J73ty14218pB9ugh9Ifi8E6Uq547tNIQTYgpklAfBXTE+gxC
	 nWWI1cPaV9kVPJfHTvu757TCE17vfqBJGE11hAXo=
X-Original-To: cygwin AT cygwin DOT com
Delivered-To: cygwin AT cygwin DOT com
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ED214386F037
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=DZWilyAfAWqHSpCY1GbER5ZuCHis8em/YehkqiYNtQ4=;
 b=Nto4+yhbcglHsmzf56dF40j59eqDqKFIzVoefN30D8M1ZIlcnctPCDOpfxlBOmQg9U
 9D7eeSyQg8+b7EWWYQ9v3N3RKfIDxwzoP7hWlC6gbPCMabSNYU0iMx0acC71UyDilwUO
 gtxLAeTmHbg94jvONN9Q37MwCl3W0A6+1o6Z/DvBnkJysvMpTfldLj4mQ/g0AEj+J8lZ
 8T1lhf6qz1dgMCHanv+I9cC/zt9gocik20qFqSjrg3YmgDEOjf3QAOazBk+aALhEh8CN
 o05ixbitKJbit3ubu1alCjYdHiEM8V2SYuMxiE30uNlKtMSheYuFK9byvntNUNIi5a0z
 FwSA==
X-Gm-Message-State: AOAM531r5ihoOpBptkTkrn50m466CKm6WEhxuz32PnIqllpnNf+up8Gy
 PZDm80Pil7v7N6WTU/kCK1A2HhK9mPNOGdNVnMA=
X-Google-Smtp-Source: ABdhPJyTMRt657ACytMKWjbkE7cX0KCkOdkCEsJREIWFLerhgi+4f7oWMUehdHw+nJfO74pgUFiit93iyU47C49JCS0=
X-Received: by 2002:a02:cd2b:: with SMTP id h11mr10062462jaq.47.1590926462344; 
 Sun, 31 May 2020 05:01:02 -0700 (PDT)
MIME-Version: 1.0
References: <CADbiGS7HpQanb1seVLu8O8QqB+G_FN2mc-cgeoo7Hx-NnM7w3Q AT mail DOT gmail DOT com>
 <20200531010628 DOT da3864bdc895a02b768bb694 AT nifty DOT ne DOT jp>
 <20200531180439 DOT 3f6a13db1ffa6ed1df39959a AT nifty DOT ne DOT jp>
In-Reply-To: <20200531180439.3f6a13db1ffa6ed1df39959a@nifty.ne.jp>
Date: Sun, 31 May 2020 13:00:51 +0100
Message-ID: <CADbiGS62rVmYtBc=R8g=DFZErP+aUFxzwdXS=XF8WL+1vv0N2Q@mail.gmail.com>
Subject: Re: Repeated input in PTY with SSH when a native process runs a
 Cygwin process that consumes input
To: Takashi Yano <takashi DOT yano AT nifty DOT ne DOT jp>
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00, DKIM_SIGNED,
 DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,
 SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: cygwin AT cygwin DOT com
X-Mailman-Version: 2.1.29
List-Id: General Cygwin discussions and problem reports <cygwin.cygwin.com>
List-Archive: <https://cygwin.com/pipermail/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-request AT cygwin DOT com?subject=help>
List-Subscribe: <http://cygwin.com/mailman/listinfo/cygwin>,
 <mailto:cygwin-request AT cygwin DOT com?subject=subscribe>
From: Andrew Ng via Cygwin <cygwin AT cygwin DOT com>
Reply-To: Andrew Ng <anng DOT sw AT gmail DOT com>
Cc: cygwin AT cygwin DOT com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "Cygwin" <cygwin-bounces AT cygwin DOT com>

Hi Takashi,

> The developers snapshot, in which the issue has been fixed,
> is ready. Could you please test?

Thanks for the fast response.

I have tested the snapshot and can confirm that it fixes the issue. I
have also applied the same fix to MSYS2 and confirmed the issue is
fixed there too.

I did take a look at the code when I came across this issue and I
noticed a few things that looked a bit odd. I noticed that the
following functions appear to make use of rabuf () without
consideration for raixget ():

  fhandler_termios::eat_readahead
  fhandler_pty_master::accept_input
  fhandler_pty_master::transfer_input_to_pcon

Also fhandler_pty_slave::eat_readahead does 'eols' processing without
any guard on is_line_input (), which seems to differ from the code
pattern seen elsewhere.

I don't know if these are important, but thought I should mention
them, just in case.

Thanks,
Andrew
--
Problem reports:      https://cygwin.com/problems.html
FAQ:                  https://cygwin.com/faq/
Documentation:        https://cygwin.com/docs.html
Unsubscribe info:     https://cygwin.com/ml/#unsubscribe-simple