X-Recipient: archive-cygwin AT delorie DOT com
DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:cc:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; q=dns; s=default; b=Sya7I/TdRfO2/d03
	JnePV673hf/njZvroH8YvMpznLIyUPCxbgmKURmnauzUPduhCg3mJePYtCY3T3Cu
	CC8Lf8DrdzO/1YSLC31+uWsKsWA+fdk/gTzq20dHgNCCnkg55bKSZq9Hy+fFwhWO
	4A8PIYfhgWxjm75pWGbuUE57Y34=
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id
	:list-unsubscribe:list-subscribe:list-archive:list-post
	:list-help:sender:subject:to:references:cc:from:message-id:date
	:mime-version:in-reply-to:content-type
	:content-transfer-encoding; s=default; bh=kznnbRftjlB3GVqo3CGvf0
	1X58E=; b=nCMtMxS6m0OgTbqf3w1EpB+IipYUZblYaonWBUJ0cPVj99KC9UXiOP
	DmmsjHWwoL5dKh20pkKOpfnimyH8cBc2ZcM5a7idGZUjGjAMhCy9pnjzz+vLQgPg
	vyi9Z/PLv22WL+T9GnQ3qtBX2dZabBzX8wB0o3l+IMOJl0rtixk0E=
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_40,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=calm, UD:mksetupini.py, l63, mksetupini.py
X-HELO: out4-smtp.messagingengine.com
X-ME-Sender: <xms:tOYeWud5QMpq65xouGHpD2cJXX9YTaZ_iM8k3sr26ZdCyl1IeAggSA>
Subject: Re: mksetupini does not return error code
To: The Cygwin Mailing List <cygwin AT cygwin DOT com>
References: <CAL_02JBwqseAuH+N+-AE-5A9bs1Y-Nvrt080e-p88pHwVy4mGA AT mail DOT gmail DOT com>
Cc: Ivan Gagis <igagis AT gmail DOT com>
From: Jon Turney <jon DOT turney AT dronecode DOT org DOT uk>
Message-ID: <48faa710-3f06-c2b0-64ec-057fc965aa4c@dronecode.org.uk>
Date: Wed, 29 Nov 2017 16:56:18 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAL_02JBwqseAuH+N+-AE-5A9bs1Y-Nvrt080e-p88pHwVy4mGA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 29/11/2017 14:58, Ivan Gagis wrote:
> Hi,
> 
> I found that in case packages validation fails the mksetup script just
> returns success, though it prints a line in the console saying
> "mksetupini: package set has errors, not writing setup.ini".
> 
> I think it should return some error code so that it would not be
> considered as success by CI scripts where mksetupini is called from.
> 
> The problematic lines are as following:
> 
> https://cygwin.com/git/?p=cygwin-apps/calm.git;a=blob;f=calm/mksetupini.py;h=f24e4c5751e1f7e13516e8689c041403ba1f8d38;hb=HEAD#l63
> returns nothing, should return non-zero error code.
> 
> https://cygwin.com/git/?p=cygwin-apps/calm.git;a=blob;f=calm/mksetupini.py;h=f24e4c5751e1f7e13516e8689c041403ba1f8d38;hb=HEAD#l118
> returns nothing, should return result of do_main().
> 
> I'm not familiar with python, so I don't submit a patch, but even
> without knowing python it is clearly seen that the errors are not
> returned properly.

Yeah, this is a bit of an oversight.  Thanks for pointing it out.


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple