X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Wed, 2 Feb 2011 10:58:51 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: err.h declarations not marked noreturn.
Message-ID: <20110202095851.GA32233@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <AANLkTimhvza1E0bj7EmBURK+Sc22R9x265sjLdVxeNAw AT mail DOT gmail DOT com> <201102011259 DOT 53193 DOT rusty AT rustcorp DOT com DOT au> <AANLkTimViNGmPH0q8h1gASOYiD1mYqowDRJTecAbx+1O AT mail DOT gmail DOT com> <201102020911 DOT 31282 DOT rusty AT rustcorp DOT com DOT au> <4D489B12 DOT 4080807 AT redhat DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4D489B12.4080807@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Feb  1 16:45, Eric Blake wrote:
> On 02/01/2011 03:41 PM, Rusty Russell wrote:
> > OK, your /usr/include/err.h doesn't have the annotations to tell gcc that it
> > doesn't return.
> 
> I'm a bit surprised that cygwin provides the BSD interface err() but
> lacks the glibc interface error() from "error.h", even though both
> interfaces are equally non-standard, and cygwin strives more for Linux
> compatibility.  [...]

That's a clear case of 
http://cygwin.com/acronyms/#SHTDI
http://cygwin.com/acronyms/#PTC

> > Mine looks like so (Ubuntu):
> > 
> > 	extern void err (int __status, __const char *__format, ...)
> > 	     __attribute__ ((__noreturn__, __format__ (__printf__, 2, 3)));
> 
> But it is indeed the case that the BSD interface err() always calls
> exit() (see cygwin/libc/bsdlib.cc in the sources), and could therefore
> be marked noreturn in the headers if someone were to provide a patch.

...as long as we don't just copy the Linux headers for licensing
reasons.

> 
> > 
> > I've CC'd the cygwin list: there might be a good reason why they don't
> > have annotations on their err.h, or it might just be an omission.
> 
> An unintentional omission, because no one has complained about it in the
> past.  In fact, there are a LOT of useful gcc attributes that could be
> added to various headers throughout the cygwin and newlib projects.

See above.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple