X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-2.1 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_LOW
X-Spam-Check-By: sourceware.org
Message-ID: <4CAB42BA.2000303@cwilson.fastmail.fm>
Date: Tue, 05 Oct 2010 11:22:34 -0400
From: Charles Wilson <cygwin AT cwilson DOT fastmail DOT fm>
Reply-To: Charles Wilson <cygwin AT cwilson DOT fastmail DOT fm>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: rebaseall on [1.7] : first glitch for ages
References: <4CAB15A6 DOT 1020007 AT bonhard DOT uklinux DOT net> <20101005130824 DOT GA3224 AT tishler DOT net> <4CAB3208 DOT 701 AT cwilson DOT fastmail DOT fm>
In-Reply-To: <4CAB3208.701@cwilson.fastmail.fm>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On 10/5/2010 10:11 AM, Charles Wilson wrote:
> On 10/5/2010 9:08 AM, Jason Tishler wrote:
>> rebase will skip some errors (e.g., when a DLL is not writable), but
>> will exit if FixImage() fails.  Maybe rebase should skip this error too?
> 
> I don't think so -- what if the DLL was "partially" written, and some
> other failure occurred?  I'd want to know right away.  FixImage should
> probably, for now, just return without error if the image is 64bit.

I realize that last sentence was unclear. What I meant was, FixImage()
should check if the DLL is 64bit, and if so then *do nothing*, and
return without error.  OTOH, for 32bit DLLs, FixImage() should retain
its current behavior of returning WITH error if anything goes wrong.

At least, until rebase gains the ability to act on 64bit DLLs.

--
Chuck

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple