X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-0.7 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,T_TO_NO_BRKTS_FREEMAIL
X-Spam-Check-By: sourceware.org
MIME-Version: 1.0
In-Reply-To: <20100817090816.GB16404@calimero.vinschen.de>
References: <AANLkTimQfeALLK=x_UvJYLjusd6ygCtjUKDrdA91e7Ej AT mail DOT gmail DOT com>	<20100812225838 DOT GB15724 AT ednor DOT casa DOT cgf DOT cx>	<4C647D32 DOT 1090907 AT redhat DOT com>	<AANLkTikCc0gdoVTWfhp=xoNY_m=Up4XQiApLmm9K9da+@mail.gmail.com>	<AANLkTin_VGPC-qfVROBhyFqcU0DBD5B8RAxLCF9RsNDC AT mail DOT gmail DOT com>	<20100817090816 DOT GB16404 AT calimero DOT vinschen DOT de>
Date: Tue, 17 Aug 2010 22:44:07 -0300
Message-ID: <AANLkTimnEpcPfYmV0WcM4RGp=wP6pPXp68bECSW4eeX2@mail.gmail.com>
Subject: Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff
From: Pedro Izecksohn <pedro DOT izecksohn AT gmail DOT com>
To: cygwin AT cygwin DOT com
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

--- Corinna Vinschen wrote:
>
> For this patch, given that it is just a bunch of rather obvious
> defines, I don't think we have to treat the patch as significant.

  I do not think that these macros are obvious. I think that I was
there when these macros were first implemented at 1987: I talked with
the programmer who was paid by the Correios to port everything from
the mainframe to the Apple II. I was a stenchy kid with his father,
that asked the employee what he was doing. When I asked about other
possibilities of endianness, the programmer answered about the PDP.
The programmer explained about BSD being a flavor of Unix. That talk
changed my life.

> However, please don't use _BSD_SOURCE. =C2=A0The newlib/Cygwin headers are
> not set up like the Linux headers and the big bunch of definitions from
> /usr/include/features.h are not available so far. =C2=A0The _BSD_SOURCE
> define is not honored or set anywhere right now.
>
> What you can do is to use _POSIX_SOURCE. =C2=A0So, if you're going to use
> #ifndef _POSIX_SOURCE instead, and if you're creating a ChangeLog entry
> in the correct ChangeLog entry format (see the ChangeLog file), then
> I guess we can check it in.

  Would you agree with:

#if defined _BSD_SOURCE || ! defined _POSIX_SOURCE

  ?

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple