X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Wed, 9 Dec 2009 12:56:49 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: UTF-8 in Cygwin console on 1.7
Message-ID: <20091209115649.GM8059@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <4B1E4D22 DOT 9020406 AT hones DOT org DOT uk>  <416096c60912080520l49cbf64bwa4a2c4510b13a9f0 AT mail DOT gmail DOT com>  <4B1E56D1 DOT 2090501 AT hones DOT org DOT uk>  <416096c60912081305k3d386207q5d6fb6cdc77c47a AT mail DOT gmail DOT com>  <4B1F29F0 DOT 7020701 AT hones DOT org DOT uk>  <416096c60912082136x316686b3gab4275c9ac5736de AT mail DOT gmail DOT com>  <4B1F8BA3 DOT 3070302 AT towo DOT net>  <416096c60912090348u4a2180e6w4d613346cbbf92bd AT mail DOT gmail DOT com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <416096c60912090348u4a2180e6w4d613346cbbf92bd@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Dec  9 11:48, Andy Koppe wrote:
> 2009/12/9 Thomas Wolff:
> > So the #define IGN should go as well...
> 
> Yep.
> 
> > Actually, I don't really understand this code part:
> > * What is the purpose of the lookup table for the switch rather than just
> > switching on a few special control characters?
> 
> Good question.
> 
> > * What is the idea of (randomly?) assigning ERR to some control characters
> > and NOR to others?
> 
> I wondered about that too.
> 
> > * How does the case NOR *work* actually?
> 
> Due to the code around line 1530 for dealing with multibyte chars.
> Further deepens the mystery regarding the ERR/NOR distinction though.
> Do only certain control chars (if any) appear in doublebyte encodings?
> 
> > Maybe after clarifying this, the whole snipplet should be cleaned up a
> > little bit.
> 
> Sounds like a good addition to your console patch.

I'd rather have multiple smaller patches which change stuff independently
of each other.  One big patch with multiple motley changes is quite hard
to examine.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple