X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: sourceware.org
Message-ID: <4ACE3545.7070904@cwilson.fastmail.fm>
Date: Thu, 08 Oct 2009 14:53:57 -0400
From: Charles Wilson <cygwin AT cwilson DOT fastmail DOT fm>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.23) Gecko/20090812 Thunderbird/2.0.0.23 Mnenhy/0.7.6.666
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: gdb, insight, and tcltk
References: <4ACD0C50 DOT 2010902 AT cwilson DOT fastmail DOT fm>
In-Reply-To: <4ACD0C50.2010902@cwilson.fastmail.fm>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

The existing cygwin gdb/insight 6.8-2 package has the following change:

2007-11-30  Pedro Alves  <...>

	* i386-tdep.c (struct i386_frame_cache): Rename saved_sp to
	prev_frame_sp.  Add saved_sp_regnum field.
	(i386_alloc_frame_cache): Update.
	(i386_analyze_stack_align): Record which register holds %esp in
	saved_sp_regnum.
	(i386_analyze_register_saves): Move higher on the file.
	(i386_analyze_frame_setup): Account for register saves before stack
	adjustment.
	(i386_frame_cache): If possible, prefer reading the register that holds
	the previous stack pointer from the stack .
	(i386_frame_prev_register): Update.
	(i386_frame_args_address): New.
	(i386_frame_base): Set i386_frame_args_address as args method.

(patch vs. "regular" gdb-6.8 attached).  However, I *think* that given this:

http://sourceware.org/ml/gdb-cvs/2008-08/msg00053.html

Discussion here:
http://sourceware.org/ml/gdb-patches/2008-07/msg00575.html
http://sourceware.org/ml/gdb-patches/2008-08/msg00141.html

that Pedro's change is now unnecessary (it certainly needs a lot of TLC
to apply to 7.0, in any case).  Also: gdb/insight built without this
change seem to work ok.

Any thoughts?

--
Chuck

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple