X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Message-ID: <4A6F14B6.4000107@hones.org.uk>
Date: Tue, 28 Jul 2009 16:09:42 +0100
From: Cliff Hones <cliff AT hones DOT org DOT uk>
User-Agent: Thunderbird 2.0.0.22 (Windows/20090605)
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: Odd directory created when installing 1.7
References: <4A6E4A0C DOT 9000503 AT hones DOT org DOT uk> <20090728102724 DOT GO18621 AT calimero DOT vinschen DOT de> <4A6EFBEB DOT 8030800 AT hones DOT org DOT uk> <4A6F0096 DOT 9000209 AT hones DOT org DOT uk> <20090728144024 DOT GU18621 AT calimero DOT vinschen DOT de>
In-Reply-To: <20090728144024.GU18621@calimero.vinschen.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Spam-Score: -2.6 (--) (knockando.watchfront.net.uk)
X-Spam-Report: knockando.watchfront.net.uk has scanned this email for spam. Results:- 	BAYES_00=-2.599 (total -2.6, current threshold 4.0)
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

Corinna Vinschen wrote:
> On Jul 28 14:43, Cliff Hones wrote:
>> Cliff Hones wrote:
>>> .. One further possibly useful piece
>>> of informaion - the create timestamps on the odd directories are all the
>>> same, and 14 seconds later than the timestamp on the correct "dev" directory.
>> Looking at the install log, I see this timestamp matches the time the
>> bash.sh postinstall was run, so it would have been this snippet which
>> did it, I imagine:
>>
>>   # Install /dev/fd, /dev/std{in,out,err}.  The bash builtin test was compiled
>>   # to assume these exist, so use /bin/test to really check.
>>   DEVDIR="$(cygpath -au "C:/$(cygpath -am /dev/)" | sed 's|/c/\(.\):/|/\1/|')"
>>   mkdir -p "$DEVDIR" || result=1
> 
> Hmm, this looks kind of fragile.  Not to say it looks wrong.
> 
> $ cygpath -am /dev/
> C:/cygwin/dev
> 
> Ok.
> 
> $ echo "C:/$(cygpath -am /dev/)"
> C:/C:/cygwin/dev
> 
> Huh?
> 
> $ cygpath -au "C:/$(cygpath -am /dev/)"
> /cygdrive/c/C:/cygwin/dev
> 
> Huh^2?
> 
> $ echo "$(cygpath -au "C:/$(cygpath -am /dev/)" | sed 's|/c/\(.\):/|/\1/|')"
> /cygdrive/C/cygwin/dev
> 
> That's ok again, but is it always right?  I can't believe it.

No - it's not right with my setup - where I have C:\ mounted as /C.
With Cygwin 1.5 (which has exactly the same bash.sh) I get
DEVDIR=/C/c:/cygwin/dev, and with 1.7 I get /C/C:/cygwin1.7/dev.
Interestingly, the 1.7 install seems to have detected my 1.5
mount points and preserved them - I wasn't expecting that.

I guess this must have been broken on 1.5 for ages, but did no harm
as the create would fail as ":" was invalid in filenames.

> Already using the fixed "C:/" in the expression is incorrect, given
> that everybody is free to install Cygwin to a non-C: drive.

Would it have been a workaround for buggy cygpath or setup.exe in
the past?

> What this postinstall script should do is just this:
> 
>   mkdir -p /dev || result=1
> 
> or to drop the mkdir entirely since the /dev/ dir has been already
> created by the 000-cygwin-post-install.sh script.

Quite.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple