X-Recipient: archive-cygwin AT delorie DOT com
X-SWARE-Spam-Status: No, hits=1.2 required=5.0 	tests=AWL,BAYES_00,HK_OBFDOM,J_CHICKENPOX_42
X-Spam-Check-By: sourceware.org
X-TPG-Junk-Checked: Yes
X-TPG-Junk-Status: Message not scanned because user authenticated using SMTP AUTH
X-TPG-Abuse: host=123-243-74-63.tpgi.com.au; ip=123.243.74.63; date=Thu, 23 Jul 2009 03:02:52 +1000; auth=a/dd58RmThMRQbJLhdmDwr/fcSovfa0vOzWc399V3Kc=
Message-ID: <4A674637.5040803@shaddybaddah.name>
Date: Thu, 23 Jul 2009 03:02:47 +1000
From: Shaddy Baddah <helium AT shaddybaddah DOT name>
User-Agent: Thunderbird 2.0.0.22 (Windows/20090605)
MIME-Version: 1.0
To: cygwin AT cygwin DOT com
Subject: Re: Yesterday's CVS ci solved VBoxSharedFolderFS issues
References: <20090722155241 DOT GM27613 AT calimero DOT vinschen DOT de>
In-Reply-To: <20090722155241.GM27613@calimero.vinschen.de>
Content-Type: multipart/mixed;  boundary="------------090806070207000107020709"
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

--------------090806070207000107020709
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Corinna,

Corinna Vinschen wrote:
>> The only thing obviously broken now are symlinks. I've done some
>> debugging and tracked it down to the fact that any call like this:
>>
>> path.c:2254:      if (NT_SUCCESS (status)
>> path.c:2255:      && NT_SUCCESS (status
>> path.c:2256:             = NtQueryInformationFile (h, &io, &fbi, sizeof fbi,
>> path.c:2257:                           FileBasicInformation)))
>>
>> will return STATUS_NOT_SUPPORTED. I will need to do some further
>> learning to understand if this is a show stopper for symlinks,
>> although any wisdom dispensed would be greatly appreciated.
>>     
>
> Is ity possible that the status code is not the one from
> the NtQueryInformationFile call but rather from the
> NtCreateFile call before?  In that case the first NT_SUCCESS (status)
> is what fails.
>
> A couple of lines above, line 2211ff, there's this:
>
> ...
>
> There are two places which check for STATUS_EAS_NOT_SUPPORTED.
> If you check additionally for STATUS_NOT_SUPPORTED in both places,
> does it work now?
>   
That worked! Thank you very very much. I've attached the patch.

I guess it remains to be seen if there are any other issues. But so
far it's looking good :-)

Kind regards,
Shaddy


--------------090806070207000107020709
Content-Type: text/plain;
 name="vboxsymlinks.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="vboxsymlinks.diff"

Index: winsup/cygwin/path.cc
===================================================================
RCS file: /cvs/src/src/winsup/cygwin/path.cc,v
retrieving revision 1.555
diff -u -r1.555 path.cc
--- winsup/cygwin/path.cc	17 Jul 2009 09:00:19 -0000	1.555
+++ winsup/cygwin/path.cc	22 Jul 2009 16:58:00 -0000
@@ -2210,6 +2210,7 @@
 			     eabuf, easize);
       /* No right to access EAs or EAs not supported? */
       if (status == STATUS_ACCESS_DENIED || status == STATUS_EAS_NOT_SUPPORTED
+	  || status == STATUS_NOT_SUPPORTED
 	  /* Or a bug in Samba 3.2.x (x <= 7) when accessing a share's root dir
 	     which has EAs enabled? */
 	  || status == STATUS_INVALID_PARAMETER)
@@ -2217,7 +2218,7 @@
 	  no_ea = true;
 	  /* If EAs are not supported, there's no sense to check them again
 	     whith suffixes attached.  So we set eabuf/easize to 0 here once. */
-	  if (status == STATUS_EAS_NOT_SUPPORTED)
+	  if (status == STATUS_EAS_NOT_SUPPORTED || status == STATUS_NOT_SUPPORTED)
 	    {
 	      eabuf = NULL;
 	      easize = 0;


--------------090806070207000107020709
Content-Type: text/plain; charset=us-ascii

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
--------------090806070207000107020709--