X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
Date: Fri, 20 Feb 2009 14:56:35 +0100
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: [ANNOUNCEMENT] [1.7] Updated: file-5.00-1
Message-ID: <20090220135635.GA6398@calimero.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <announce DOT 20090210093102 DOT GB11175 AT calimero DOT vinschen DOT de> <499E2B9A DOT 5030907 AT cwilson DOT fastmail DOT fm> <20090220095916 DOT GA759 AT calimero DOT vinschen DOT de> <499EB1AB DOT 9060808 AT gmail DOT com> <20090220134501 DOT GA6180 AT calimero DOT vinschen DOT de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090220134501.GA6180@calimero.vinschen.de>
User-Agent: Mutt/1.5.17 (2007-11-01)
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Feb 20 14:45, Corinna Vinschen wrote:
> On Feb 20 13:35, Dave Korn wrote:
> > magic.c:304: warning: passing argument 1 of 'strlcat' makes pointer from
> > integer without a cast
> > 
> >    304				(void)strlcat(strlcpy(tmp, inname, len), ".exe", len);
> > 
> > 
> >   That sort of construct works for "strcat (strcpy ())" but not for the 'l'
> > versions, they aren't drop-in replacements.
> 
> Urgh!

Upstream has changed my code!  Sacrilege!

Fortunately this code won't be used anymore in Cygwin 1.7 because 1.7
appends the .exe suffix in calls to open transparently.

I'll send a fix upstream.  The fix is to remove the CYGWIN specific code.
I won't create a 1.5.x version of file >= 5.00 anyway.


Corinna

-- 
Corinna Vinschen                  Please, send mails regarding Cygwin to
Cygwin Project Co-Leader          cygwin AT cygwin DOT com
Red Hat

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/