X-Recipient: archive-cygwin AT delorie DOT com
X-Spam-Check-By: sourceware.org
To: cygwin AT cygwin DOT com
From: Herb Maeder <maeder-cygml AT maeder DOT org>
In-reply-to: Corinna Vinschen <corinna-cygwin@cygwin.com> 's message of                  Fri, 07 Nov 2008 12:00:56 +0100.
Subject: Re: [ANNOUNCEMENT] Updated: OpenSSH-5.1p1-6 (-7)
Date: Fri, 07 Nov 2008 13:37:44 -0800
Message-ID: <94965.1226093864@maeder.org>
X-IsSubscribed: yes
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Id: <cygwin.cygwin.com>
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On 07 Nov 2008 12:00:56 +0100, Corinna Vinschen wrote:   
> This is a bugfix release which fixes a bug in the ssh-host-config script
> which stumbles over user names with a substring of "ssh" in them and
> thinks that ssh processes are still running.

Is the intent now to catch only processes named 'sshd'?  If so, the
current "grep -q 'sshd*$'" may still be a little too loose.  For example, 
it could match stuff like "/home/user/flosshdd".  Ok, maybe not likely, 
but still it would cause the script to end in an error.

Assuming we can depend on "ps -ef" always printing full path names without 
any arguments, then "grep -q '/sshd$'" might do the trick.  Is there any
reason to catch multiple trailing d's?

If a more loose matching scheme is really desired, it might be helpful to 
print out the matching ps lines before generating the error (just so
that it's more obvious to the user as to what is going on).

Sorry if this is too nit-picky.  I just happened to notice it when I was
looking at other stuff.

Herb.

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/