X-Spam-Check-By: sourceware.org
Date: Mon, 22 May 2006 18:18:47 -0400 (EDT)
From: Igor Peshansky <pechtcha AT cs DOT nyu DOT edu>
Reply-To: cygwin AT cygwin DOT com
To: mwoehlke <mwoehlke AT tibco DOT com>
cc: cygwin AT cygwin DOT com
Subject: Re: Problems with setup colors in snapshot
In-Reply-To: <e4t2pp$ci8$1@sea.gmane.org>
Message-ID: <Pine.GSO.4.63.0605221811170.21697@access1.cims.nyu.edu>
References: <e4t2pp$ci8$1 AT sea DOT gmane DOT org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Mon, 22 May 2006, mwoehlke wrote:

> A while back I posted about the colors in setup.exe. I noticed that the
> text background color is fixed but that there is still a problem with
> the tree structure; specifically, the clickable [+] and [-] icons are,
> on my colors, effectively invisible. On some other color schemes I
> tried, they *are* 100% invisible.
>
> I didn't see any response last time, so... is anyone able to reproduce
> this? I know P are TC but I don't have time to play with this right now
> :-(.

Yes, this is most likely reproducible (as the foreground color of those
icons is *always* black.

Theoretically, it should be a simple matter of using MaskBlt instead of
BitBlt with the properly configured pen color and the properly set up
mask.  In practice, making this work on all platforms (including Win9x),
correctly, and with the minimum amount of code changes is a big pain.

If you're interested in looking at the code and providing a patch, grep
the setup sources for bitmap_dc (or BitBlt) and patch all those places.

If someone can take one of the bitmaps from the setup sources, and send me
a *complete* small program that draws that bitmap on a window drawing
context with the foreground and background colors coming from the Windows
color scheme, I'll see what I can do about incorporating that code into
setup.  As is, I'm too busy to wade through MSDNs incomplete documentation
on this.

> Also, thanks again to whoever fixed the text color!

The ChangeLogs should show the name of the culprit.

> More info:
>
> 0: I am looking at the latest, 2.529 snapshot of setup.exe, however I
> also see it in the (older) most recent "release" setup.exe.
>
> 1: It seems that "window background" is the only color that has any
> effect on the tree color. Therefore, the color must be somehow
> calculated from this(?). This might even be a bug in the UI component
> being used (i.e. a bug in M$ code).
>
> 2: My current "window background" color is (70,74,80), which makes the
> tree effectively invisible, but tinkering with a screenshot in M$Paint
> shows that it is still a *marginally* different color.
>
> 3: If I pick, e.g. (64,0,128) for my window background color, the tree
> becomes the *exact* same color as the background.

Hmm, weird -- for me the foreground color of the icons is *always* black.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_	    pechtcha AT cs DOT nyu DOT edu | igor AT watson DOT ibm DOT com
ZZZzz /,`.-'`'    -.  ;-;;,_		Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'		old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/