X-Spam-Check-By: sourceware.org
Date: Thu, 5 Jan 2006 21:55:31 -0500
From: Christopher Faylor <cgf-no-personal-reply-please AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: services not starting with 20060104 snapshot
Message-ID: <20060106025531.GG1937@trixie.casa.cgf.cx>
Reply-To: cygwin AT cygwin DOT com
References: <BAY108-F66824337AB6F827402541B52E0 AT phx DOT gbl> <Pine DOT GSO DOT 4 DOT 63 DOT 0601051511000 DOT 24200 AT slinky DOT cs DOT nyu DOT edu> <20060105203241 DOT GA26305 AT trixie DOT casa DOT cgf DOT cx> <Pine DOT GSO DOT 4 DOT 63 DOT 0601051605430 DOT 5388 AT slinky DOT cs DOT nyu DOT edu> <43BDB8B0 DOT 8070600 AT cygwin DOT com> <20060106005917 DOT GA1937 AT trixie DOT casa DOT cgf DOT cx> <43BDC7E5 DOT 1070809 AT cygwin DOT com> <20060106015259 DOT GC1937 AT trixie DOT casa DOT cgf DOT cx> <43BDCFCC DOT 2090305 AT cygwin DOT com> <20060106023407 DOT GE1937 AT trixie DOT casa DOT cgf DOT cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060106023407.GE1937@trixie.casa.cgf.cx>
User-Agent: Mutt/1.5.11
Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:cygwin-unsubscribe-archive-cygwin=delorie DOT com AT cygwin DOT com>
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com

On Thu, Jan 05, 2006 at 09:34:07PM -0500, Christopher Faylor wrote:
>That was supposed to fix the problem of console windows appearing when the
>service is allowed to interact with the desktop.

Does this do anything, Larry?

cgf

Index: fhandler_console.cc
===================================================================
RCS file: /cvs/uberbaum/winsup/cygwin/fhandler_console.cc,v
retrieving revision 1.155
diff -u -p -r1.155 fhandler_console.cc
--- fhandler_console.cc	5 Jan 2006 16:26:22 -0000	1.155
+++ fhandler_console.cc	6 Jan 2006 02:54:56 -0000
@@ -146,7 +146,7 @@ tty_list::get_tty (int n)
 void __stdcall
 set_console_state_for_spawn (bool noncygwin_process)
 {
-  if (noncygwin_process && fhandler_console::need_invisible ())
+  if ((1 || noncygwin_process) && fhandler_console::need_invisible ())
     return;
 
   HANDLE h = CreateFile ("CONIN$", GENERIC_READ, FILE_SHARE_WRITE,
@@ -1825,6 +1825,9 @@ fhandler_console::fixup_after_fork_exec 
 
 bool NO_COPY fhandler_console::invisible_console;
 
+// #define WINSTA_ACCESS (WINSTA_READATTRIBUTES | STANDARD_RIGHTS_READ | STANDARD_RIGHTS_WRITE | WINSTA_CREATEDESKTOP | WINSTA_EXITWINDOWS)
+#define WINSTA_ACCESS STANDARD_RIGHTS_READ
+
 bool
 fhandler_console::need_invisible ()
 {
@@ -1856,9 +1859,8 @@ fhandler_console::need_invisible ()
       h = horig = GetProcessWindowStation ();
       if (myself->ctty == -1)
 	{
-	  if (!(h = CreateWindowStation (NULL, 0, WINSTA_ALL_ACCESS, &sec_all_nih)))
-	    h = CreateWindowStation ("CygwinInvisible", 0, WINSTA_ALL_ACCESS,
-				     &sec_all_nih);
+	  if (!(h = CreateWindowStation (NULL, 0, WINSTA_ACCESS, NULL)))
+	    h = CreateWindowStation ("CygwinInvisible", 0, WINSTA_ACCESS, NULL);
 	  termios_printf ("CreateWindowStation(\"CygwinInvisible\", %p), %E", h);
 	  if (h)
 	    {


--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/