Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm
List-Subscribe: <mailto:cygwin-subscribe AT cygwin DOT com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin AT cygwin DOT com>
List-Help: <mailto:cygwin-help AT cygwin DOT com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
Delivered-To: mailing list cygwin AT cygwin DOT com
Date: Tue, 31 Aug 2004 21:08:26 +0200
From: Corinna Vinschen <corinna-cygwin AT cygwin DOT com>
To: cygwin AT cygwin DOT com
Subject: Re: RTLD_DEFAULT & RTLD_NEXT
Message-ID: <20040831190826.GV17670@cygbert.vinschen.de>
Reply-To: cygwin AT cygwin DOT com
Mail-Followup-To: cygwin AT cygwin DOT com
References: <u65704sup DOT fsf AT gnu DOT org> <20040830143832 DOT GE17670 AT cygbert DOT vinschen DOT de> <uisb018x4 DOT fsf AT gnu DOT org> <20040831083258 DOT GA7517 AT cygbert DOT vinschen DOT de> <u1xhn1gaz DOT fsf AT gnu DOT org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <u1xhn1gaz.fsf@gnu.org>
User-Agent: Mutt/1.4.2i

Hi Sam,

On Aug 31 11:24, Sam Steingold wrote:
> > * Corinna Vinschen <pbevaan-pltjva AT pltjva DOT pbz> [2004-08-31 10:32:58 +0200]:
> > EnumProcessModules.  This should also allow to implement RTLD_DEFAULT.
> 
> 2004-08-31  Sam Steingold  <sds AT gnu DOT org>
> 
> 	* dlfcn.cc (dlsym): Handle RTLD_DEFAULT using EnumProcessModules().
> 	* include/dlfcn.h (RTLD_DEFAULT): Define to NULL.

thanks but... well, there are a couple of problems:

- Please send patches to cygwin-patches@...

- Your code doesn't follow the GNU coding style.

- EnumProcessModules is NT >= 4 only but not loaded dynamically (see
  autoload.cc) nor tested for non-existance.  Generally, EnumProcessModules
  is called w/o checking the return value.
  
- This is adding new functionality.  It's not much over the usual 10
  lines rule of thumb for trivial patches, but it's not exactly trivial
  functionality and it will only grow bigger when adding the autoload
  and return value testing code.  I'd like to ask you to read
  http://cygwin.com/contrib.html and send us a copyright assignment if
  possible.


Thanks,
Corinna

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/