Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Date: Tue, 4 Jun 2002 21:15:39 -0400 From: Christopher Faylor To: cygwin AT cygwin DOT com Subject: Re: [PATCH] _unlink() & rmdir() on /proc/* Message-ID: <20020605011539.GC13492@redhat.com> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com References: <11415277457 DOT 20020604143720 AT syntrex DOT com> <008501c20c25$f41d9d60$0100a8c0 AT advent02> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <008501c20c25$f41d9d60$0100a8c0@advent02> User-Agent: Mutt/1.3.23.1i On Wed, Jun 05, 2002 at 01:14:26AM +0100, Chris January wrote: >> P.S. I don't expect this patches to be applied because they may look >> like ugly hacks or something like that... I didn't find any more >> appropriate way to fix this though without greater modifications to >> the code. I see several ways of fixing this in a much better way: >> >> 1. unlink () and rmdir () should be made virtual functions in >> fhandler_base. > >Chris, what are yout thoughts on this? At the moment, not enough file I/O >functions have been moved to fhandler_base to implement a read/write pseudo >filesystem using fhandler_virtual. This was one of the main reasons that >/proc/registry is read-only. I agree that unlink, rmdir, chdir, and probably a host of others should be moved into fhandler. Having done this with fstat, opendir, readdir, etc., recently, I know this isn't a trivial thing to do however. cgf -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/