Mailing-List: contact cygwin-help AT cygwin DOT com; run by ezmlm List-Subscribe: List-Archive: List-Post: List-Help: , Sender: cygwin-owner AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com Delivered-To: mailing list cygwin AT cygwin DOT com Date: Wed, 22 May 2002 11:56:31 -0400 From: Christopher Faylor To: cygwin AT cygwin DOT com Subject: Re: setup-2.243 Crash / Install from Local Directory / WinXP Message-ID: <20020522155631.GA2782@redhat.com> Reply-To: cygwin AT cygwin DOT com Mail-Followup-To: cygwin AT cygwin DOT com References: <14818658940 DOT 20020522143447 AT syntrex DOT com> <2525705071 DOT 20020522163213 AT syntrex DOT com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2525705071.20020522163213@syntrex.com> User-Agent: Mutt/1.3.23.1i On Wed, May 22, 2002 at 04:32:13PM +0200, Pavel Tsekov wrote: >Wednesday, May 22, 2002, 2:34:47 PM, you wrote: > >PT> I can confirm this - here is the output shown from Dr. Mingw JIT: > >I'm not sure this is the same crash but the crash I'm reporting is >easy reproducable and I think it is not the expected behaviour :) >Here is more info on it.. > >The crash is caused by this code from IniParseFindVisitor.cc, line 62: > > /* Copy leading part of path to temporary buffer and unescape it */ > > String prefix (&basePath.cstr_oneuse()[baseLength + 1]); > String mirror = rfc1738_unescape_part (prefix.substr(0,prefix.size() - 1)); > > baseLenght - the length of the fullpath to the local package dir > basePath - the full path of a directory we are currently scanning > with FindFirstFile and friends. > >When scannin the local package directory itself prefix would be with >zero length. Now prefix.size() will result in 0 thus this call >prefix.substr(0,prefix.size() - 1) will look like this >prefix.substr(0, -1) i.e. give me the whole string. Ok fine... >Now take a look at String::substr: Heh. Sounds very similar to the problem that I fixed in the branch. cgf -- Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple Bug reporting: http://cygwin.com/bugs.html Documentation: http://cygwin.com/docs.html FAQ: http://cygwin.com/faq/