Subject: Re: localtime
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Georg Nikodym <georgn@bitmover.com>
In-Reply-To: <4DF8F426.7040705@gmail.com>
Date: Wed, 15 Jun 2011 14:46:00 -0400
Cc: cygwin@cygwin.com
Reply-To: cygwin@cygwin.com
Message-Id: <62E96F23-86D9-4C60-AE4C-BA3BC2FD49D3@bitmover.com>
References: <4DF8CF3D.40104@gmail.com> <4DF8EA79.2060404@gmail.com> <20110615173847.GB23078@ednor.casa.cgf.cx> <4DF8EF9F.4090906@gmail.com> <20110615174805.GC23078@ednor.casa.cgf.cx> <4DF8F426.7040705@gmail.com>
To: Tod <listacctc@gmail.com>
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
Precedence: bulk
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Content-Transfer-Encoding: 8bit


On 2011-06-15, at 2:04 PM, Tod wrote:

> Ok, right - duh.  Let me back up a couple of steps.
> 
> I'm passing a 128 byte char array.  I allocated it to provide enough room for the date/time stamp this function is returning.  strlen(tout) will resolve to the length of the tout string.
> 
> You said above that I shouldn't be using strlen(tout) and instead I should be passing 128.  Would I be better off using sizeof(tout) instead?

Answered by Steve Thompson.

> Also, the code has always worked.  I just recompiled it recently.  Now the date works but the time isn't appearing.  What could be causing that?

It worked by accident, not by design.  strlen simply counts bytes until it sees a zero.  In previous runs you were lucky that the memory pointed to by tout didn't have a zero in the first N bytes where N was enough to hold the result from strftime().

None of this is a cygwin issue.  Just very basic C programming.

-g


--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple