X-Recipient: archive-cygwin@delorie.com
X-SWARE-Spam-Status: No, hits=-1.9 required=5.0	tests=BAYES_00
X-Spam-Check-By: sourceware.org
From: Rusty Russell <rusty@rustcorp.com.au>
To: Reini Urban <rurban@x-ray.at>
Subject: err.h declarations not marked noreturn.
Date: Wed, 2 Feb 2011 09:11:31 +1030
User-Agent: KMail/1.13.5 (Linux/2.6.35-24-generic; KDE/4.5.1; i686; ; )
Cc: cygwin@cygwin.com
References: <AANLkTimhvza1E0bj7EmBURK+Sc22R9x265sjLdVxeNAw@mail.gmail.com> <201102011259.53193.rusty@rustcorp.com.au> <AANLkTimViNGmPH0q8h1gASOYiD1mYqowDRJTecAbx+1O@mail.gmail.com>
In-Reply-To: <AANLkTimViNGmPH0q8h1gASOYiD1mYqowDRJTecAbx+1O@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201102020911.31282.rusty@rustcorp.com.au>
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-help@cygwin.com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Delivered-To: mailing list cygwin@cygwin.com

On Wed, 2 Feb 2011 01:56:44 am Reini Urban wrote:
> 2011/2/1 Rusty Russell <rusty@rustcorp.com.au>:
> > On Mon, 31 Jan 2011 11:41:33 pm Reini Urban wrote:
> >> gcc-4.3.4 cygwin
...
> > Can you send me (privately) the output of gcc -E on that file?  That
> > should tell me for sure.  A ccan/err module might be a good start.
> 
> Attached.

OK, your /usr/include/err.h doesn't have the annotations to tell gcc that it
doesn't return.

Mine looks like so (Ubuntu):

	extern void err (int __status, __const char *__format, ...)
	     __attribute__ ((__noreturn__, __format__ (__printf__, 2, 3)));

I've CC'd the cygwin list: there might be a good reason why they don't
have annotations on their err.h, or it might just be an omission.

Thanks,
Rusty.

--
Problem reports:       http://cygwin.com/problems.html
FAQ:                   http://cygwin.com/faq/
Documentation:         http://cygwin.com/docs.html
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple

