X-Recipient: archive-cygwin@delorie.com
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Message-ID: <49AD4174.6040906@gmail.com>
Date: Tue, 03 Mar 2009 14:40:52 +0000
From: Dave Korn <dave.korn.cygwin@googlemail.com>
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: Dave Korn <dave.korn.cygwin@googlemail.com>
CC: cygwin@cygwin.com
Subject: Re: [1.7] rebaseall doesn't solve the problem
References: <499F6682.1090204@cwilson.fastmail.fm> <20090224100616.GC6035@calimero.vinschen.de> <49A85971.6070300@cwilson.fastmail.fm> <20090228104337.GG19887@calimero.vinschen.de> <49A986B4.2080501@cwilson.fastmail.fm> <20090228195127.GA26646@ednor.casa.cgf.cx> <20090228202850.GB8503@calimero.vinschen.de> <20090302120756.GA31166@calimero.vinschen.de> <49ABF7B5.5010605@cwilson.fastmail.fm> <49AC56FE.4080708@gmail.com> <49AC90A5.2080001@cwilson.fastmail.fm> <49AC9BAB.9000700@gmail.com>
In-Reply-To: <49AC9BAB.9000700@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact cygwin-help@cygwin.com; run by ezmlm
List-Id: <cygwin.cygwin.com>
List-Subscribe: <mailto:cygwin-subscribe@cygwin.com>
List-Archive: <http://sourceware.org/ml/cygwin/>
List-Post: <mailto:cygwin@cygwin.com>
List-Help: <mailto:cygwin-help@cygwin.com>, <http://sourceware.org/ml/#faqs>
Sender: cygwin-owner@cygwin.com
Mail-Followup-To: cygwin@cygwin.com
Delivered-To: mailing list cygwin@cygwin.com

Dave Korn wrote:
> 
>   Nope, should be easy to cut out the relevant bits, discarding ld-isms, and
> paste the remainder into your code.  Copy of WIP attached for your
> convenience; I've got to add doco and testcases before I can submit it, but
> the parsing stuff is ready to fly and I'd appreciate any extra testing it gets :)

  Two bugfixes FYI:

static void
set_pe_value_from_flags (char *name)

after
      /* Deliberately allow multiple conjoined separators.  */
      while (is_flag_sep (*optarg))
	optarg++;
add
      /* Even trailing at the end.  */
      if (!*optarg)
	break;

change
      /* If there's any more, we do insist on at least one separator.  */
      if (optarg && !is_flag_sep (*optarg))
to
      /* If there's any more, we do insist on at least one separator.  */
      if (*optarg && !is_flag_sep (*optarg))



    cheers,
      DaveK

--
Unsubscribe info:      http://cygwin.com/ml/#unsubscribe-simple
Problem reports:       http://cygwin.com/problems.html
Documentation:         http://cygwin.com/docs.html
FAQ:                   http://cygwin.com/faq/