www.delorie.com/archives/browse.cgi   search  
Mail Archives: geda-user/2021/09/26/14:12:11.1

X-Authentication-Warning: delorie.com: mail set sender to geda-user-bounces using -f
X-Recipient: geda-user AT delorie DOT com
X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7+dev
X-Exmh-Isig-CompType: repl
X-Exmh-Isig-Folder: inbox
From: "karl AT aspodata DOT se [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
To: geda-user AT delorie DOT com
Mail-Followup-To: geda-user AT delorie DOT com
Subject: Re: [geda-user] empty attributes
In-reply-to: <YVCID768IBVWAKQp@lepton>
References: <20210925133011 DOT D0B918587B70 AT turkos DOT aspodata DOT se> <alpine DOT DEB DOT 2 DOT 21 DOT 2109251919580 DOT 1189 AT nimbus> <20210925194712 DOT 152EA8587FD0 AT turkos DOT aspodata DOT se> <YVA9ZAI1l0KKaA/d AT lepton> <20210926135916 DOT C448E8587FD6 AT turkos DOT aspodata DOT se> <YVCID768IBVWAKQp AT lepton>
Comments: In-reply-to "Vladimir Zhbanov (vzhbanov AT gmail DOT com) [via geda-user AT delorie DOT com]" <geda-user AT delorie DOT com>
message dated "Sun, 26 Sep 2021 17:47:43 +0300."
Mime-Version: 1.0
Message-Id: <20210926181115.415248587FD8@turkos.aspodata.se>
Date: Sun, 26 Sep 2021 20:11:15 +0200 (CEST)
X-Virus-Scanned: ClamAV using ClamSMTP
Reply-To: geda-user AT delorie DOT com
Errors-To: nobody AT delorie DOT com
X-Mailing-List: geda-user AT delorie DOT com
X-Unsubscribes-To: listserv AT delorie DOT com

Vladimir:
...
> It has nothing to do with guile.  The code is still in C,
> somewhere in o_attrib.c.  It may affect all tools in the project,
> though.

ooh, thank god!

$ git diff
diff --git a/liblepton/src/o_attrib.c b/liblepton/src/o_attrib.c
index bb533a751..785ed155e 100644
--- a/liblepton/src/o_attrib.c
+++ b/liblepton/src/o_attrib.c
@@ -355,7 +355,7 @@ o_attrib_string_get_name_value (const gchar *string, gchar **name_ptr, gchar **v
   prev_char = g_utf8_find_prev_char (string, ptr);
   next_char = g_utf8_find_next_char (ptr, NULL);
   if (prev_char == NULL || *prev_char == ' ' ||
-      next_char == NULL || *next_char == ' ' || *next_char == '\0' ) {
+      next_char == NULL || *next_char == ' ' ) {
     return FALSE;
   }

 Same files as before:
http://aspodata.se/tmp/Test/attrib_unknown/
 but with empty value in refdes:
C 15600 7000 1 0 0 down.src.sym
{
T 17000 9439 5 10 1 0 0 3 1
refdes=
T 17000 9217 5 10 1 1 0 3 1
source=down.sch
}

$ lepton-sch2pcb top.sch > /dev/null
$ cat top.net 
unnamed_net1    R1-1 R3-2
unnamed_net2    R2-1 R3-1
unnamed_net3    R1-2 R2-2
$

Mission accomplished!

Regards,
/Karl Hammar


- Raw text -


  webmaster     delorie software   privacy  
  Copyright © 2019   by DJ Delorie     Updated Jul 2019